-
Couldn't load subscription status.
- Fork 134
add initial binary implementation for vmcp #2340
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2340 +/- ##
==========================================
- Coverage 54.28% 54.10% -0.18%
==========================================
Files 240 242 +2
Lines 23594 23661 +67
==========================================
- Hits 12808 12802 -6
- Misses 9577 9647 +70
- Partials 1209 1212 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This will be the entrypoint for the vmcp component See https://github.com/stacklok/stacklok-epics/issues/153
c71d250 to
49d7d5a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces the foundational infrastructure for a new standalone binary called vmcp (Virtual MCP Server), which will serve as an aggregation proxy for multiple MCP (Model Context Protocol) servers. The implementation focuses on establishing the binary structure, CLI commands, and build/CI configuration without the full functional implementation.
Key Changes:
- Added new
vmcpbinary with CLI structure (serve, validate, version commands) - Integrated build tasks and container image builds for the new binary
- Extended CI/CD pipeline to build and publish vmcp container images
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| cmd/vmcp/main.go | Entry point for the vmcp binary with signal handling |
| cmd/vmcp/app/commands.go | CLI command structure with placeholder implementations |
| cmd/vmcp/README.md | Comprehensive documentation for vmcp usage and configuration |
| examples/vmcp-config.yaml | Example configuration file demonstrating vmcp settings |
| docs/vmcp-implementation-summary.md | Implementation status and architecture documentation |
| Taskfile.yml | Build tasks for vmcp binary and container image |
| .github/workflows/image-build-and-publish.yml | CI/CD pipeline job for building and publishing vmcp images |
| .github/ko-ci.yml | ko build configuration for vmcp |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| config: | ||
| command: "python" | ||
| args: ["-m", "mcp_git"] | ||
| tool_prefix: "git_" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't really match the configuration we've defined.
| @@ -0,0 +1,156 @@ | |||
| # Virtual MCP Server (vmcp) - Foundational Infrastructure | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there's probably no need to persist this just yet.
This will be the entrypoint for the vmcp component
See https://github.com/stacklok/stacklok-epics/issues/153