Skip to content

Conversation

@yrobla
Copy link
Contributor

@yrobla yrobla commented Oct 27, 2025

This will be the entrypoint for the vmcp component

See https://github.com/stacklok/stacklok-epics/issues/153

@codecov
Copy link

codecov bot commented Oct 27, 2025

Codecov Report

❌ Patch coverage is 0% with 67 lines in your changes missing coverage. Please review.
✅ Project coverage is 54.10%. Comparing base (0c44157) to head (b56d157).

Files with missing lines Patch % Lines
cmd/vmcp/app/commands.go 0.00% 60 Missing ⚠️
cmd/vmcp/main.go 0.00% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2340      +/-   ##
==========================================
- Coverage   54.28%   54.10%   -0.18%     
==========================================
  Files         240      242       +2     
  Lines       23594    23661      +67     
==========================================
- Hits        12808    12802       -6     
- Misses       9577     9647      +70     
- Partials     1209     1212       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@yrobla yrobla requested review from JAORMX and Copilot October 27, 2025 16:28
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces the foundational infrastructure for a new standalone binary called vmcp (Virtual MCP Server), which will serve as an aggregation proxy for multiple MCP (Model Context Protocol) servers. The implementation focuses on establishing the binary structure, CLI commands, and build/CI configuration without the full functional implementation.

Key Changes:

  • Added new vmcp binary with CLI structure (serve, validate, version commands)
  • Integrated build tasks and container image builds for the new binary
  • Extended CI/CD pipeline to build and publish vmcp container images

Reviewed Changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
cmd/vmcp/main.go Entry point for the vmcp binary with signal handling
cmd/vmcp/app/commands.go CLI command structure with placeholder implementations
cmd/vmcp/README.md Comprehensive documentation for vmcp usage and configuration
examples/vmcp-config.yaml Example configuration file demonstrating vmcp settings
docs/vmcp-implementation-summary.md Implementation status and architecture documentation
Taskfile.yml Build tasks for vmcp binary and container image
.github/workflows/image-build-and-publish.yml CI/CD pipeline job for building and publishing vmcp images
.github/ko-ci.yml ko build configuration for vmcp

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

config:
command: "python"
args: ["-m", "mcp_git"]
tool_prefix: "git_"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't really match the configuration we've defined.

@@ -0,0 +1,156 @@
# Virtual MCP Server (vmcp) - Foundational Infrastructure
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there's probably no need to persist this just yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants