-
Couldn't load subscription status.
- Fork 134
Add Dockerfile UBI images for the Operator and ProxyRunner #2327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
874deb3 to
4f9dc0f
Compare
|
@TomerFi I was more thinking about creating additional UBI images, not replacing the ones we have. |
|
Perhaps we could have a |
@JAORMX , I'm not sure I follow, do you want two build processes to exist simultaneously? One using ko.build and one using Dockerfile? |
|
@TomerFi that's right |
|
@JAORMX May I ask why? |
|
@TomerFi because I would like to keep the |
driven by env vars or always 2 images per application? in the first case, what's the default? |
|
So, I was thinking of having: How this happens is not super important to me. It could be another workflow that happens after the main build depending on the main release workflow. perhaps? |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2327 +/- ##
==========================================
- Coverage 54.27% 54.23% -0.04%
==========================================
Files 242 242
Lines 23446 23446
==========================================
- Hits 12725 12716 -9
- Misses 9506 9520 +14
+ Partials 1215 1210 -5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
I like this scheme. As upstream, we should commit to maintaining UBI images - OpenShift is a very important downstream. But at the same I'd like us to keep the ko-based images as they are minimal, small and distroless. As far as making it easier for clients to find and distinguish the images, perhaps we could add OCI image labels, e.g. And I guess it would be nice to have a helm chart variable to easily switch between them. (those can be another PR, just thinking out loud how to make life easier for consumers) |
3d74330 to
33d0b8e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this look good, I wouldn't mind pushing this as long as it keeps moving you forward. I wasn't sure about the LDFLAGS invocation though and left a question.
2b2bc35 to
ac773b2
Compare
Signed-off-by: Tomer Figenblat <tfigenbl@redhat.com>
Signed-off-by: Tomer Figenblat <tfigenbl@redhat.com>
e511a36 to
e9b313b
Compare
Signed-off-by: Tomer Figenblat <tfigenbl@redhat.com>
This PR adds Dockerfile-based build and push processes for both the Operator and ProxyRunner images. These UBI-based images are passing OpenShift-Preflight tests by introducing a more secure base image.