Add env package for testable environment variable access#3
Merged
Conversation
Graduate the env package from toolhive to toolhive-core as the first Tier 1 package per THV-0032 RFC. This package provides: - Reader interface for environment variable access - OSReader implementation using the standard os package - Mock implementation for testing The package has zero dependencies on ToolHive internals and uses only the standard library, making it ideal for the first graduation. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
jhrozek
approved these changes
Feb 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
envpackage from toolhive as the first Tier 1 package per THV-0032 RFCReaderinterface for dependency injection and testing isolationOSReaderimplementation using standard libraryospackageTest plan
task lintpassestask license-checkpassestask testpasses with race detectionNotes
This is the first package graduation to toolhive-core. The
envpackage was chosen because:ospackage)🤖 Generated with Claude Code