Skip to content

Conversation

@peppescg
Copy link
Collaborator

@peppescg peppescg commented Nov 27, 2025

Auth:

  • replace import from constant rather read directly from env in auth.ts
  • leverage scopes from env var

nit: I replace the title, description metadata and removed a bunch of leftover vercel svg

@peppescg peppescg self-assigned this Nov 27, 2025
Copilot AI review requested due to automatic review settings November 27, 2025 10:13
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR makes the OIDC scopes configurable via environment variable instead of using hardcoded values. The changes centralize configuration by moving OIDC_CLIENT_ID and OIDC_CLIENT_SECRET to use imported constants and introduce a new OIDC_SCOPES environment variable.

Key Changes:

  • Added OIDC_SCOPES constant that parses comma-separated scopes from environment variable
  • Refactored auth configuration to use imported constants instead of inline environment variable access
  • Replaced hardcoded scopes array ["openid", "email", "profile", "offline_access"] with configurable OIDC_SCOPES

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File Description
src/lib/auth/constants.ts Adds new OIDC_SCOPES constant that parses comma-separated scopes from OIDC_SCOPES environment variable
src/lib/auth/auth.ts Updates OIDC configuration to use imported constants (OIDC_CLIENT_ID, OIDC_CLIENT_SECRET, OIDC_SCOPES) instead of inline environment variable access and hardcoded values

@peppescg peppescg merged commit a2bb4f5 into main Nov 27, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants