Skip to content
This repository was archived by the owner on Jun 5, 2025. It is now read-only.

Print the container logs on test failure #895

Merged
merged 2 commits into from
Feb 4, 2025
Merged

Print the container logs on test failure #895

merged 2 commits into from
Feb 4, 2025

Conversation

@rdimitrov
Copy link
Member

@rdimitrov rdimitrov commented Feb 3, 2025 •
edited
Loading

The following PR updates the conditions for printing the container logs:

  • always() runs on failures and even on canceled jobs
  • added it to enforce printing the vllm/ollama logs in case of a failure

@rdimitrov
Print the container logs on test failure
d46747c 
Signed-off-by: Radoslav Dimitrov <radoslav@stacklok.com>
@rdimitrov
Go back to always()
048ce03 
Signed-off-by: Radoslav Dimitrov <radoslav@stacklok.com>
@lukehinds lukehinds merged commit eba27f9 into main Feb 4, 2025
9 checks passed
@lukehinds lukehinds deleted the fix-always branch February 4, 2025 07:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@aponcedeleonch aponcedeleonch aponcedeleonch approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@rdimitrov @aponcedeleonch @lukehinds