Fix greenlet dependency in poetry lock file.
#712
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It looks like poetry on macOS does not install `greenlet`, while it does on Linux, both for version 1.8.4 and 2.0.1, which seems to be a bug. Additionally, failures only manifest after _using_ codegate, and not during startup. This change adds `greenlet` package to `pyproject.toml`.
blkt
force-pushed
the
chore/fix-poetry-greenlet
branch
from
c14f61a to
14ce5cf
Compare
JAORMX
reviewed
Jan 22, 2025
pyproject.toml
Outdated
| @@ -29,6 +29,7 @@ tree-sitter-rust = "==0.23.2" | |||
| alembic = "==1.14.1" | |||
| pygments = "==2.19.1" | |||
| sqlite-vec-sl-tmp = "==0.0.4" | |||
| greenlet = "^3.1.1" | |||
There was a problem hiding this comment.
can we pin this dependency?
lukehinds
previously approved these changes
Jan 22, 2025
|
@dependabot rebase |
JAORMX
approved these changes
Jan 22, 2025
aponcedeleonch
approved these changes
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like poetry on macOS does not install
greenlet, while it does on Linux, both for version 1.8.4 and 2.0.1, which seems to be a bug. Additionally, failures only manifest after using codegate, and not during startup.This change adds
greenletpackage topyproject.toml.