This repository was archived by the owner on Jul 8, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 6
feat: implement breadcrumbs according to design #131
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dfedc62 to
15f26b9
Compare
Collaborator
Pull Request Test Coverage Report for Build 12870483113Details
💛 - Coveralls |
kantord
commented
Jan 20, 2025
| <> | ||
| <Breadcrumbs> | ||
| <BreadcrumbHome /> | ||
| <Breadcrumb>Help</Breadcrumb> |
Member
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
imo this should extract the title from the document somehow, maybe using front matter yaml. but that's a bit too complex to include in this PR
Member
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
or else we can switch to mdx, which would allow us to put the breadcrumbs react component into the markdown file itself, avoiding the need for any custom logic. That would work well unless we want to build a full fledged documentation feature with dozens of files
alex-mcgovern
approved these changes
Jan 20, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #122
What's included:
Record_select-area_20250120154700.mp4