Add request type muxing #96
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| WS1 --> |FIM requests| LLM1 | ||
| WS1 --> |Chat| LLM2 | ||
| WS2 --> |.md files| LLM2 | ||
| WS2 --> |.js files| LLM3 | ||
| WS3 --> |All prompts| LLM3 |
There was a problem hiding this comment.
I have one suggestion for .tsx and .ts files...actually if we have a .ts rule with an higher priority than .tsx we are going to match always the .ts rule.
So I would specify this in the doc
There was a problem hiding this comment.
I fixed this part in the code, i.e. now it will correctly match .tsx and .ts
There was a problem hiding this comment.
I just added a note about precedence to the PR based on @peppescg's original comment, is that not correct now?
There was a problem hiding this comment.
The note I added says:
Keep substring matching in mind. For example, if you have a filter for
.tsfiles placed above a rule for.tsxfiles, the.tsxrule cannot be reached because the.tsfilter matches first.
I think that's still accurate?
There was a problem hiding this comment.
I think my suggestion could be skipped now, cause @aponcedeleonch fixed in the code directly, sorry @danbarr 🙏
There was a problem hiding this comment.
Nope, not accurate anymore since we're using a more explicit function to evaluate the substrings. We were using a simple in and now we use endswith. Check the following python output
>>> file = "test.tsx"
>>> ".ts" in file
True
>>> file.endswith(".ts")
FalseThere was a problem hiding this comment.
OK I just updated again based on our conversation, I think this is now accurate to the current behavior: 5302bb2
Closes #90