Skip to content

feat(alb) migrate to versioned sdk - #1327

Merged
rubenhoenle merged 2 commits into
mainfrom
feat/STACKITTPR-533_alb-sdk-migration
Mar 27, 2026
Merged

rubenhoenle merged 2 commits into
mainfrom
feat/STACKITTPR-533_alb-sdk-migration

Conversation

@cgoetz-inovex

Copy link
Copy Markdown
Contributor

STACKITTPR-533

Description

relates to #1234

Checklist

  • Issue was linked above
  • Code format was applied: make fmt
  • Examples were added / adjusted (see examples/ directory)
  • Docs are up-to-date: make generate-docs (will be checked by CI)
  • Unit tests got implemented or updated
  • Acceptance tests got implemented or updated (see e.g. here)
  • Unit tests are passing: make test (will be checked by CI)
  • No linter issues: make lint (will be checked by CI)

Comment thread stackit/internal/conversion/conversion.go
rubenhoenle
rubenhoenle previously approved these changes Mar 26, 2026

@rubenhoenle rubenhoenle left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest looks good.

@rubenhoenle
rubenhoenle enabled auto-merge (squash) March 27, 2026 16:43
@rubenhoenle
rubenhoenle force-pushed the feat/STACKITTPR-533_alb-sdk-migration branch from 3a1c33d to e2b117f Compare March 27, 2026 16:43
@rubenhoenle
rubenhoenle merged commit 24eac4d into main Mar 27, 2026
3 checks passed
@rubenhoenle
rubenhoenle deleted the feat/STACKITTPR-533_alb-sdk-migration branch March 27, 2026 16:47
@github-actions

Copy link
Copy Markdown

Merging this branch will increase overall coverage

Impacted Packages Coverage Δ 🤖
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/conversion 42.59% (+9.57%) 👍
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/alb 0.00% (ø)
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/alb/applicationloadbalancer 64.34% (ø)
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/alb/utils 75.00% (ø)

Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/conversion/conversion.go 42.59% (+9.57%) 108 (+2) 46 (+11) 62 (-9) 👍
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/alb/applicationloadbalancer/datasource.go 0.00% (ø) 43 0 43
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/alb/applicationloadbalancer/resource.go 67.31% (ø) 933 628 305
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/alb/utils/util.go 75.00% (ø) 8 6 2

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files

  • github.com/stackitcloud/terraform-provider-stackit/stackit/internal/conversion/conversion_test.go
  • github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/alb/alb_acc_test.go
  • github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/alb/applicationloadbalancer/resource_test.go
  • github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/alb/utils/util_test.go

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants