Skip to content

Conversation

@rubenhoenle
Copy link
Member

Description

relates to STACKITTPR-373

Checklist

  • Issue was linked above
  • Code format was applied: make fmt
  • Examples were added / adjusted (see examples/ directory)
  • Docs are up-to-date: make generate-docs (will be checked by CI)
  • Unit tests got implemented or updated
  • Acceptance tests got implemented or updated (see e.g. here)
  • Unit tests are passing: make test (will be checked by CI)
  • No linter issues: make lint (will be checked by CI)

@rubenhoenle rubenhoenle force-pushed the fix/STACKITTPR-373-dns-store-ids-after-provisioning branch from d25b221 to 9fea21f Compare October 13, 2025 11:40
@rubenhoenle rubenhoenle marked this pull request as ready for review October 13, 2025 11:40
@rubenhoenle rubenhoenle requested a review from a team as a code owner October 13, 2025 11:40
@rubenhoenle rubenhoenle force-pushed the fix/STACKITTPR-373-dns-store-ids-after-provisioning branch from 9fea21f to 567d016 Compare October 14, 2025 13:02
@rubenhoenle rubenhoenle self-assigned this Oct 14, 2025
@rubenhoenle rubenhoenle force-pushed the fix/STACKITTPR-373-dns-store-ids-after-provisioning branch from 567d016 to 2cbbf6b Compare October 15, 2025 09:12
@rubenhoenle rubenhoenle enabled auto-merge (squash) October 15, 2025 09:13
@rubenhoenle rubenhoenle merged commit 4103c33 into main Oct 15, 2025
5 checks passed
@rubenhoenle rubenhoenle deleted the fix/STACKITTPR-373-dns-store-ids-after-provisioning branch October 15, 2025 09:16
@github-actions
Copy link

Merging this branch will increase overall coverage

Impacted Packages Coverage Δ 🤖
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/dns/recordset 21.17% (ø)
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/dns/zone 22.03% (+0.46%) 👍
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/utils 82.08% (+0.52%) 👍

Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/dns/recordset/resource.go 25.82% (ø) 182 47 135
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/dns/zone/resource.go 28.73% (+0.77%) 181 (-5) 52 129 (-5) 👍
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/utils/utils.go 81.08% (+0.80%) 74 (+3) 60 (+3) 14 👍

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files

  • github.com/stackitcloud/terraform-provider-stackit/stackit/internal/utils/utils_test.go

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants