Skip to content

Feat/stackitsdk 129 onboarding of kms service #1924

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Apr 29, 2025
Merged

Feat/stackitsdk 129 onboarding of kms service #1924

merged 10 commits into from
Apr 29, 2025

Conversation

bahkauv70
Copy link
Contributor

@bahkauv70 bahkauv70 commented Apr 28, 2025 •
edited
Loading

Description

Integration of the key management API. Provide generated code and required waiters.

Checklist

  • Issue was linked above
  • No generated code was adjusted manually (check comments in file header)
  • Changelogs
    • Changelog in the root directory was adjusted (see here)
    • Changelog(s) of the service(s) were adjusted (see e.g. here)
  • Code format was applied: make fmt
  • Examples were added / adjusted (see examples/ directory)
  • Unit tests got implemented or updated
  • Unit tests are passing: make test (will be checked by CI)
  • No linter issues: make lint (will be checked by CI)

@bahkauv70 bahkauv70 marked this pull request as ready for review April 28, 2025 09:53
@bahkauv70 bahkauv70 force-pushed the feat/stackitsdk-129-Onboarding-of-KMS-service branch 2 times, most recently from 58b2e72 to a6d6959 Compare April 28, 2025 11:49
marceljk
marceljk reviewed Apr 28, 2025
View reviewed changes
marceljk
marceljk previously approved these changes Apr 28, 2025
View reviewed changes
@bahkauv70 bahkauv70 force-pushed the feat/stackitsdk-129-Onboarding-of-KMS-service branch from 4ee456c to bb1c7b5 Compare April 29, 2025 07:06
@bahkauv70 bahkauv70 force-pushed the feat/stackitsdk-129-Onboarding-of-KMS-service branch from bb1c7b5 to b61d910 Compare April 29, 2025 07:09
@bahkauv70 bahkauv70 enabled auto-merge (squash) April 29, 2025 07:14
@bahkauv70 bahkauv70 requested a review from marceljk April 29, 2025 07:14
@bahkauv70 bahkauv70 merged commit 8527d0a into main Apr 29, 2025
8 checks passed
@bahkauv70 bahkauv70 deleted the feat/stackitsdk-129-Onboarding-of-KMS-service branch April 29, 2025 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marceljk marceljk marceljk approved these changes

@Fyusel Fyusel Awaiting requested review from Fyusel

@rubenhoenle rubenhoenle Awaiting requested review from rubenhoenle

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bahkauv70 @marceljk