Skip to content

Conversation

@rubenhoenle
Copy link
Member

@rubenhoenle rubenhoenle commented Sep 5, 2025

Description

relates to STACKITCLI-242

Checklist

  • Issue was linked above
  • Code format was applied: make fmt
  • Examples were added / adjusted (see e.g. here)
  • Docs are up-to-date: make generate-docs (will be checked by CI)
  • Unit tests got implemented or updated
  • Unit tests are passing: make test (will be checked by CI)
  • No linter issues: make lint (will be checked by CI)

@rubenhoenle rubenhoenle requested a review from a team as a code owner September 5, 2025 13:16
@rubenhoenle rubenhoenle enabled auto-merge (squash) September 5, 2025 13:17
@rubenhoenle rubenhoenle force-pushed the fix/redis-list-command-json-output branch from cea3718 to 5f9df60 Compare September 10, 2025 09:28
@rubenhoenle rubenhoenle self-assigned this Sep 10, 2025
@rubenhoenle rubenhoenle merged commit 2efac7d into main Sep 10, 2025
5 checks passed
@rubenhoenle rubenhoenle deleted the fix/redis-list-command-json-output branch September 10, 2025 09:33
@github-actions
Copy link

Merging this branch will increase overall coverage

Impacted Packages Coverage Δ 🤖
github.com/stackitcloud/stackit-cli/internal/cmd/redis/credentials/list 46.15% (+3.97%) 👍
github.com/stackitcloud/stackit-cli/internal/cmd/redis/instance/list 44.62% (+3.99%) 👍

Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/stackitcloud/stackit-cli/internal/cmd/redis/credentials/list/list.go 46.15% (+3.97%) 65 (+1) 30 (+3) 35 (-2) 👍
github.com/stackitcloud/stackit-cli/internal/cmd/redis/instance/list/list.go 44.62% (+3.99%) 65 (+1) 29 (+3) 36 (-2) 👍

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files

  • github.com/stackitcloud/stackit-cli/internal/cmd/redis/credentials/list/list_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/redis/instance/list/list_test.go

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants