chore(loadbalancer): regional adjustment #652
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
relates to STACKITCLI-127
rubenhoenle
requested review from
Fyusel,
bahkauv70 and
marceljk
as code owners
marceljk
reviewed
Mar 18, 2025
Contributor
marceljk
left a comment
marceljk
left a comment
There was a problem hiding this comment.
Looks in general good! The only thing what needs to be changed is the following:
From:
stackit-cli/internal/pkg/services/load-balancer/client/client.go
Lines 30 to 31 in 526183a
to:
} else {
cfgOptions = append(cfgOptions, authCfgOption)
}Because with the current state, the region config will be used to define the region within the client. This isn't possible after the region adjustment and throws an error
marceljk
approved these changes
Mar 19, 2025
rubenhoenle
deleted the
chore/STACKITCLI-127-region-adjustment-loadbalancer
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
relates to STACKITCLI-127