Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Synchronise yoga with upstream #138

Merged
merged 5 commits into from
Jun 19, 2023
Merged

Synchronise yoga with upstream #138

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
64d2d6f
Update gitignore for .vscode/ configuration files
Alex-Welsh May 30, 2023
8e26267
Allow to use own repos.y[a]ml file to build containers
mmalchuk Jun 9, 2022
8f3496c
Install ncclient even in check mode
priteau Jun 1, 2023
ea47fac
Merge "Install ncclient even in check mode" into stable/yoga
Jun 5, 2023
dc90bc5
Merge "Allow to use own repos.y[a]ml file to build containers" into s…
Jun 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Install ncclient even in check mode 
When running `kayobe physical network configure --check` against Juniper
switches, Kayobe may fail with the following error:

    Failed to import the required Python library (ncclient)

This is because the ncclient installation task is skipped by check mode.

Change-Id: I643f54a67edfe22a3fd5c86f157bd1246d617399
(cherry picked from commit 7b8abfb)
  • Loading branch information
@priteau @markgoddard
priteau authored and markgoddard committed Jun 5, 2023
commit 8f3496cbea122db4e9e28c8ce201c735c59c6983
1 change: 1 addition & 0 deletions ansible/roles/junos-switch/tasks/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
name: "ncclient{{ ncclient_version }}"
virtualenv: "{{ lookup('env', 'VIRTUAL_ENV') | default(omit, true) }}"
become: "{{ lookup('env', 'VIRTUAL_ENV') == None }}"
check_mode: false
run_once: true

- name: Ensure Juniper switches are configured
Expand Down
5 changes: 5 additions & 0 deletions releasenotes/notes/ncclient-install-check-mode-0cfc7e846f3a978a.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
fixes:
- |
Installs ``ncclient`` dependency for Juniper switch configuration when
using Ansible check mode.