Skip to content

Commit

Permalink
Merge pull request #120 from markgoddard/bits-n-bobs
Browse files Browse the repository at this point in the history
Virtualenv parent dir creation, ansible_user_id, ironic rescue interfaces
  • Loading branch information
markgoddard authored Feb 1, 2018
2 parents 76197d9 + b32d9e4 commit 435298b
Show file tree
Hide file tree
Showing 7 changed files with 46 additions and 5 deletions.
9 changes: 9 additions & 0 deletions ansible/group_vars/all/ironic
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,15 @@ kolla_ironic_enabled_raid_interfaces:
# raid_interface field set.
kolla_ironic_default_raid_interface: no-raid

# Specify the list of rescue interfaces to load during service initialization.
kolla_ironic_enabled_rescue_interfaces:
- agent
- no-rescue

# Default rescue interface to be used for nodes that do not have
# rescue_interface field set.
kolla_ironic_default_rescue_interface: no-rescue

# Specify the list of storage interfaces to load during
# service initialization.
#kolla_ironic_enabled_storage_interfaces:
Expand Down
9 changes: 9 additions & 0 deletions ansible/roles/kolla-ansible/tasks/install.yml
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,15 @@
version: "{{ kolla_ansible_source_version }}"
when: kolla_ansible_ctl_install_type == 'source'

- name: Ensure virtualenv parent directory exists
file:
path: "{{ kolla_ansible_venv | dirname }}"
state: directory
owner: "{{ ansible_user_id }}"
group: "{{ ansible_user_id }}"
become: True
when: kolla_ansible_venv is not none

- name: Ensure the latest version of pip is installed
pip:
name: "{{ item.name }}"
Expand Down
7 changes: 7 additions & 0 deletions ansible/roles/kolla-openstack/defaults/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -124,6 +124,13 @@ kolla_ironic_enabled_raid_interfaces: []
# raid_interface field set.
kolla_ironic_default_raid_interface:

# Specify the list of rescue interfaces to load during service initialization.
kolla_ironic_enabled_rescue_interfaces: []

# Default rescue interface to be used for nodes that do not have
# rescue_interface field set.
kolla_ironic_default_rescue_interface:

# Specify the list of storage interfaces to load during
# service initialization.
kolla_ironic_enabled_storage_interfaces: []
Expand Down
2 changes: 1 addition & 1 deletion ansible/roles/kolla-openstack/templates/ironic.conf.j2
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ enabled_hardware_types: {{ kolla_ironic_enabled_hardware_types | join(',') }}

{# Add configuration of enabled and default dynamic driver interfaces. #}
{% set interfaces=['boot', 'console', 'deploy', 'inspect', 'management',
'network', 'power', 'raid', 'storage', 'vendor'] %}
'network', 'power', 'raid', 'rescue', 'storage', 'vendor'] %}
{% for interface in interfaces %}
{% if hostvars[inventory_hostname]['kolla_ironic_enabled_' ~ interface ~ '_interfaces'] | default %}
{{ 'enabled_' ~ interface ~ '_interfaces' }} = {{ hostvars[inventory_hostname]['kolla_ironic_enabled_' ~ interface ~ '_interfaces'] | join(',') }}
Expand Down
4 changes: 2 additions & 2 deletions ansible/roles/kolla/tasks/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@
file:
path: "{{ item }}"
state: directory
owner: "{{ ansible_user }}"
group: "{{ ansible_user }}"
owner: "{{ ansible_user_id }}"
group: "{{ ansible_user_id }}"
mode: 0750
become: True
with_items:
Expand Down
13 changes: 11 additions & 2 deletions ansible/roles/kolla/tasks/install.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,8 @@
file:
path: "{{ kolla_source_path | dirname }}"
state: directory
owner: "{{ ansible_user }}"
group: "{{ ansible_user }}"
owner: "{{ ansible_user_id }}"
group: "{{ ansible_user_id }}"
become: True
when: kolla_ctl_install_type == 'source'

Expand All @@ -34,6 +34,15 @@
version: "{{ kolla_source_version }}"
when: kolla_ctl_install_type == 'source'

- name: Ensure virtualenv parent directory exists
file:
path: "{{ kolla_venv | dirname }}"
state: directory
owner: "{{ ansible_user_id }}"
group: "{{ ansible_user_id }}"
become: True
when: kolla_venv is not none

- name: Ensure the latest version of pip is installed
pip:
name: "{{ item.name }}"
Expand Down
7 changes: 7 additions & 0 deletions etc/kayobe/ironic.yml
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,13 @@
# raid_interface field set.
#kolla_ironic_default_raid_interface:

# Specify the list of rescue interfaces to load during service initialization.
#kolla_ironic_enabled_rescue_interfaces:

# Default rescue interface to be used for nodes that do not have
# rescue_interface field set.
#kolla_ironic_default_rescue_interface:

# Specify the list of storage interfaces to load during
# service initialization.
#kolla_ironic_enabled_storage_interfaces:
Expand Down

0 comments on commit 435298b

Please sign in to comment.