slurm.conf contains malformed (trimmed) templates

[tom91136]

I saw a few instances where the templated config end up looking like:

# many more normal lines
SlurmctldHost=mgmt.staging.local#SlurmctldHost=
# many more normal lines
SlurmctldParameters=enable_configlessReturnToService=2

Which corresponds to trimmed blocks:

ansible-role-openhpc/templates/slurm.conf.j2

Line 186 in a599130

{% if openhpc_slurm_configless %}SlurmctldParameters=enable_configless{% endif %}

This may have occurred for other templates as well, but I'll have to check.
The documentation seems to suggest that this trimming of the template is the default but behaviour can be changed: ansible/ansible#22531

[sjpb]

@bertiethorpe I just found this bug report 🤦 presumably what's knackered our returntoservice

[sjpb]

@bertiethorpe I just checked and https://github.com/stackhpc/ansible-role-openhpc/pull/173/files only fixed the ReturnToService - the issue here is wider.

[sjpb]

@bertiethorpe presumably with the current fix we also shouldn't need https://github.com/stackhpc/ansible-slurm-appliance/blob/main/environments/common/inventory/group_vars/all/openhpc.yml#L38?

[sjpb]

@bertiethorpe yeah the first problem shown above is still a problem.

ClusterName=RL9
SlurmctldHost=RL9-control#SlurmctldHost=

Turns out my understanding of trim_blocks (on by default for Ansible) was wrong - I thought it only removed newlines if the entire line was otherwise a block - it is actually:

trim_blocks, the first newline after a template tag is removed automatically (like in PHP).

so we should review the entire template ...

See https://jinja.palletsprojects.com/en/stable/templates/#whitespace-control

[sjpb]

Actually the fix in 173 doesn't appear to be in master either, which is weird?

[sjpb]

Ahh, #174 nuked it :-(

[sjpb]

Fixed by https://github.com/stackhpc/ansible-role-openhpc/releases/tag/v0.29.0