Fix prechecks group exist check

[darmach]

Fixes group existence assert to iterate over groups instead of group_names.

[gemini-code-assist]

Summary of Changes

Hello @darmach, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a bug in the Ansible prechecks responsible for verifying the presence of necessary groups. The fix involves updating the assertion logic to correctly iterate over the groups variable instead of group_names, ensuring that the precheck accurately determines if a specified Ansible group exists. This prevents potential misconfigurations or failures during deployment due to an incorrect group existence check.

Highlights

• Precheck Logic Fix: Corrected an Ansible precheck assertion that verifies the existence of required groups by changing the variable used from group_names to groups for accurate checking.
• Changelog Update: Added a changelog entry for version 1.19.2 under bugfixes, documenting the fix for the prechecks group existence assertion.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

The pull request correctly fixes a bug in the pre-check logic by using the groups variable instead of group_names to verify the existence of required Ansible inventory groups. This ensures the check is performed against all defined groups, not just the ones the current host belongs to. However, there is a small typo in the changelog file that needs to be addressed.