Skip to content

fix embed list bullet to render at top of embed #2221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 17, 2025

Conversation

brymut
Copy link
Contributor

@brymut brymut commented Jun 12, 2025

Description

Fix to make listed embeds in markdown render the bullets at the top of embeds rather that the bottom
closes #2204

Tested using:

- https://www.youtube.com/watch?v=TA5nwAKav6A&t=544s
- https://x.com/unusual_whales/status/1933171682505814096
- https://primal.net/e/nevent1qqsphjsyk2l8uw5y3jun0nyjp26efe8lc2glj9584gg8mmlg7d7nmugzrlygy
- https://wavlake.com/track/4f596f59-4dc3-4eb0-8ea7-a4bdf9d13585
- https://open.spotify.com/track/4LhRPmfYakIKSWWwGAFOPj?si=0s7pjVyJRCCaMKk9yZNWxA
- https://rumble.com/embed/v6nspz0/?pub=3dskgx
- https://peertube.tv/w/cU3WYY81yg3Hpz53aujv3k
- https://bitcointv.com/w/fZkPWnEgRTfrUGCCDDbRTv
- https://github.com/stackernews/stacker.news/issues/2204

Screenshots

testinglistembeds.mov

Additional Context

Was anything unclear during your work on this PR? Anything we should definitely take a closer look at?

Checklist

Are your changes backwards compatible? Please answer below:
Y

On a scale of 1-10 how well and how have you QA'd this change and any features it might affect? Please answer below:
10

For frontend changes: Tested on mobile, light and dark mode? Please answer below:

Did you introduce any new environment variables? If so, call them out explicitly here:
No

@brymut brymut requested a review from huumn June 12, 2025 16:01
@brymut brymut marked this pull request as ready for review June 12, 2025 16:02
@huumn
Copy link
Member

huumn commented Jun 17, 2025

I made this fix also work for images/video, fixed our broken skeleton width (not the result of this change), and fixed list horizontal scroll (also not the result of this change).

@huumn huumn merged commit 6d50f7c into stackernews:master Jun 17, 2025
6 checks passed
@brymut brymut deleted the fix/tweet-embed-list branch July 31, 2025 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tweets in markdown lists render above bullet
2 participants