Skip to content

Find transforms in package.json#136

Merged
yoshuawuyts merged 1 commit intostackcss:use-transformfrom
cjhowe-us:use-transform-in-package
Oct 2, 2017
Merged

Find transforms in package.json#136
yoshuawuyts merged 1 commit intostackcss:use-transformfrom
cjhowe-us:use-transform-in-package

Conversation

@cjhowe-us
Copy link

@cjhowe-us cjhowe-us commented Sep 29, 2017

This is how I think we can pull the transform field from package.json to merge it with the options to sheetify. It's a modified version of this. However, I'm not really sure how to write the tests for it. I'm going to write an example that uses this, but we'll have to figure out how to put that into the test suite.

@cjhowe-us cjhowe-us changed the title [WIP] Find transforms in package.json Find transforms in package.json Sep 29, 2017
@cjhowe-us
Copy link
Author

cjhowe-us commented Sep 29, 2017 •
edited
Loading

Note that the failing tests for this PR are due to postcss-prefix@2.1.0 being pulled in. #135 will also fail if we run the Travis tests agains. See stackcss/postcss-prefix#12

@cjhowe-us cjhowe-us mentioned this pull request Sep 29, 2017
Merged
@cjhowe-us
Copy link
Author

cjhowe-us commented Sep 29, 2017

This should be fixed by stackcss/postcss-prefix#13

@yoshuawuyts
Copy link
Contributor

yoshuawuyts commented Sep 29, 2017

Merged the linked PR - re-running tests to see if they pass

@cjhowe-us
Copy link
Author

cjhowe-us commented Sep 29, 2017 •
edited
Loading

Indeed, it passed! Would you like me to squash the commits on this pr?

https://travis-ci.org/stackcss/sheetify/builds/281125448

EDIT: I went ahead and squashed the commits. Lots of meaningless churn.

@cjhowe-us
Copy link
Author

cjhowe-us commented Sep 29, 2017

Not really sure there's much I can do about codecov complaining about patch test coverage. The one line that is not covered in the patch wasn't covered before the patch either. I guess the indentation change made codecov think it was a new line of code? Not really sure how to cause falafel to fail, either.

https://codecov.io/gh/stackcss/sheetify/commit/a002150a17aed9b487958c23cf88c6eaf346f87b#D5-66

@stackcss stackcss deleted a comment from codecov-io Oct 2, 2017
yoshuawuyts
yoshuawuyts approved these changes Oct 2, 2017
View reviewed changes
Copy link
Contributor

@yoshuawuyts yoshuawuyts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@yoshuawuyts yoshuawuyts merged commit 242c112 into stackcss:use-transform Oct 2, 2017
@cjhowe-us
Copy link
Author

cjhowe-us commented Oct 2, 2017

👍

@cjhowe-us cjhowe-us deleted the use-transform-in-package branch October 2, 2017 16:41
yoshuawuyts added a commit that referenced this pull request Jan 2, 2018
@yoshuawuyts
use transform (#135)
875753f 
* use transform

* Add transforms from package.json (#136)

* Remove unnecessary options from transform-package tests (#137)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yoshuawuyts yoshuawuyts yoshuawuyts approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@cjhowe-us @yoshuawuyts