Skip to content

feat: add auth buttons #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 30, 2024
Merged

feat: add auth buttons #56

merged 4 commits into from
Jan 30, 2024

Conversation

ykmsd
Copy link
Contributor

@ykmsd ykmsd commented Jan 24, 2024 •
edited
Loading

  • Same as feat: add auth buttons  docs#196, adding Auth Buttons in the nav bar. Any changes made there need to be applied here too.
  • Only difference is I hide the social icons in the nav bar.

Review PR in StackBlitz Submitted with StackBlitz.

@bolt-new-by-stackblitz Bolt.new (by StackBlitz)
Copy link

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@ykmsd ykmsd requested a review from donmckenna January 24, 2024 09:18
@netlify Netlify
Copy link

netlify bot commented Jan 24, 2024 •
edited
Loading

✅ Deploy Preview for webcontainer-docs ready!

Name Link
🔨 Latest commit c0f73e4
🔍 Latest deploy log https://app.netlify.com/sites/webcontainer-docs/deploys/65b930e0b44d970008a7b514
😎 Deploy Preview https://deploy-preview-56--webcontainer-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ykmsd ykmsd changed the title [WIP] feat: add auth buttons feat: add auth buttons Jan 26, 2024
@ykmsd ykmsd marked this pull request as ready for review January 26, 2024 14:22
@ykmsd ykmsd requested a review from ggdaltoso January 26, 2024 16:53
ggdaltoso
ggdaltoso reviewed Jan 29, 2024
View reviewed changes
Copy link
Contributor

@ggdaltoso ggdaltoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to revisit the breakpoints and prevent horizontal scrolling

revisit.mp4

@ykmsd ykmsd requested a review from ggdaltoso January 30, 2024 17:24
@ggdaltoso ggdaltoso merged commit 66342eb into main Jan 30, 2024
@ggdaltoso ggdaltoso deleted the ykmsd/patch-71213 branch January 30, 2024 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@donmckenna donmckenna Awaiting requested review from donmckenna

1 more reviewer

@ggdaltoso ggdaltoso ggdaltoso approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ykmsd @ggdaltoso