feat: add file extension based icons #369
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
AriPerkkio
requested changes
Oct 10, 2024
AriPerkkio
reviewed
Oct 11, 2024
AriPerkkio
reviewed
Oct 11, 2024
AriPerkkio
approved these changes
Oct 14, 2024
There was a problem hiding this comment.
Awesome work once again @Charan167! Thanks for the PR! 🙌
These changes look good to me. Any thoughts @sulco or @Nemikolh before we merge this? This is how the example page looks like:
The available icons can be found here https://icon-sets.iconify.design/ph/?query=file- just make sure to select Duotone filter:
|
@AriPerkkio, looks good! I think we can merge it! 😃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was made to get your feedback and make the necessary changes.