Skip to content

chore: Extend post-release script to update docker-images Changelog #92

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 20, 2024
Merged

chore: Extend post-release script to update docker-images Changelog #92

merged 3 commits into from
Nov 20, 2024

Conversation

NickLarsenNZ
Copy link
Member

@NickLarsenNZ NickLarsenNZ commented Nov 19, 2024 •
edited
Loading

Fixes #83.

post-release.sh:

  • Updates docker-images CHANGELOG.md (as is done for operators).
  • Adds an option to control whether to update only operators or also products (defaults to all).
  • Removed curly braces around variables for consistency.
  • Added doc comments to each function.

I did a complete test run:

./release/create-release-branch.sh -b 24.12 -w all
./release/create-release-tag.sh -t 24.12.0 -w all
./release/post-release.sh -t 24.12.0

@NickLarsenNZ NickLarsenNZ self-assigned this Nov 19, 2024
sbernauer
sbernauer requested changes Nov 20, 2024
View reviewed changes
Copy link
Member

@sbernauer sbernauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would also let @Techassi a chance to review, as he knows this process far better than I do

@NickLarsenNZ @sbernauer
Apply suggestions from code review
5121d6a 
Co-authored-by: Sebastian Bernauer <sebastian.bernauer@stackable.de>
@NickLarsenNZ NickLarsenNZ added this pull request to the merge queue Nov 20, 2024
Merged via the queue into main with commit 41d3ef9 Nov 20, 2024
1 check passed
@NickLarsenNZ NickLarsenNZ deleted the docker-images-post-release branch November 20, 2024 08:49
@Techassi
Copy link
Member

Well, now it's gonna be very tricky to review this :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbernauer sbernauer sbernauer approved these changes

@Techassi Techassi Awaiting requested review from Techassi

Assignees

@NickLarsenNZ NickLarsenNZ

Labels
None yet
Projects
Stackable Engineering
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Extend post-release script to update docker-images Changelog
3 participants
@NickLarsenNZ @Techassi @sbernauer