-
-
Notifications
You must be signed in to change notification settings - Fork 4
feat: expose services with listener classes #562
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…to stateful set Decided to move to stateful set because deployments don't support volume claim templates.
Update: 🟢 OpenShift Tests The failed test worked too:
🟡 Openshift tests. I'll retry the failed one.
|
🟡 CI https://testing.stackable.tech/job/spark-k8s-operator-it-custom/21/ Individual failed tests ran locally successfully. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, left some nit picks which you can take or leave.
Co-authored-by: Nick <10092581+NickLarsenNZ@users.noreply.github.com>
Co-authored-by: Nick <10092581+NickLarsenNZ@users.noreply.github.com>
Co-authored-by: Nick <10092581+NickLarsenNZ@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The typical question for release notes and docs. Do we have/need them? |
Description
fixes #521
Definition of Done Checklist