Skip to content

feat: expose services with listener classes #562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 22 commits into from
May 2, 2025
Merged

feat: expose services with listener classes #562

merged 22 commits into from
May 2, 2025

Conversation

razvan
Copy link
Member

@razvan razvan commented Apr 23, 2025

Description

fixes #521

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes
# Author
- [ ] Changes are OpenShift compatible
- [ ] CRD changes approved
- [ ] CRD documentation for all fields, following the [style guide](https://docs.stackable.tech/home/nightly/contributor/docs/style-guide).
- [ ] Helm chart can be installed and deployed operator works
- [ ] Integration tests passed (for non trivial changes)
- [ ] Changes need to be "offline" compatible
# Reviewer
- [ ] Code contains useful comments
- [ ] Code contains useful logging statements
- [ ] (Integration-)Test cases added
- [ ] Documentation added or updated. Follows the [style guide](https://docs.stackable.tech/home/nightly/contributor/docs/style-guide).
- [ ] Changelog updated
- [ ] Cargo.toml only contains references to git tags (not specific commits or branches)
# Acceptance
- [ ] Feature Tracker has been updated
- [ ] Proper release label has been added
- [ ] [Roadmap](https://github.com/orgs/stackabletech/projects/25/views/1) has been updated

@razvan razvan self-assigned this Apr 23, 2025
@razvan razvan marked this pull request as ready for review April 24, 2025 11:18
@razvan razvan requested a review from a team April 24, 2025 15:14
@razvan razvan moved this to Development: Waiting for Review in Stackable Engineering Apr 24, 2025
@sbernauer sbernauer moved this from Development: Waiting for Review to Development: In Progress in Stackable Engineering Apr 28, 2025
@razvan
Copy link
Member Author

razvan commented Apr 28, 2025

Update:

🟢 OpenShift Tests

The failed test worked too:

--- PASS: kuttl (234.76s)
    --- PASS: kuttl/harness (0.00s)
        --- PASS: kuttl/harness/hbase-connector_openshift-true_spark-3.5.5_hbase-2.4.18_hdfs-latest-3.4.1_zookeeper-latest-3.9.3 (233.80s)
PASS

🟡 Openshift tests.

I'll retry the failed one.

--- FAIL: kuttl (2067.86s)
    --- FAIL: kuttl/harness (0.00s)
        --- PASS: kuttl/harness/spark-ny-public-s3_openshift-true_spark-3.5.5_s3-use-tls-true (295.99s)
        --- PASS: kuttl/harness/smoke_openshift-true_spark-3.5.5_s3-use-tls-true (328.90s)
        --- PASS: kuttl/harness/spark-pi-private-s3_openshift-true_spark-3.5.5 (159.72s)
        --- PASS: kuttl/harness/delta-lake_openshift-true_spark-delta-lake-3.5.5_delta-3.1.0 (285.77s)
        --- PASS: kuttl/harness/logging_openshift-true_spark-3.5.5_ny-tlc-report-0.2.0 (494.99s)
        --- PASS: kuttl/harness/custom-log-directory_openshift-true_spark-3.5.5_hdfs-latest-3.4.1_zookeeper-latest-3.9.3 (335.73s)
        --- PASS: kuttl/harness/spark-history-server_openshift-true_spark-3.5.5_s3-use-tls-true (333.22s)
        --- PASS: kuttl/harness/resources_openshift-true_spark-3.5.5 (125.20s)
        --- PASS: kuttl/harness/iceberg_openshift-true_spark-3.5.5 (112.71s)
        --- PASS: kuttl/harness/spark-pi-public-s3_openshift-true_spark-3.5.5 (150.47s)
        --- PASS: kuttl/harness/pyspark-ny-public-s3_openshift-true_spark-3.5.5 (188.35s)
        --- FAIL: kuttl/harness/hbase-connector_openshift-true_spark-3.5.5_hbase-2.4.18_hdfs-latest-3.4.1_zookeeper-latest-3.9.3 (591.92s)
        --- PASS: kuttl/harness/spark-examples_openshift-true_spark-3.5.5 (83.24s)
        --- PASS: kuttl/harness/pyspark-ny-public-s3-image_openshift-true_spark-3.5.5_ny-tlc-report-0.2.0 (188.66s)
        --- PASS: kuttl/harness/spark-connect_openshift-true_spark-connect-3.5.5_spark-connect-client-3.5.5 (144.05s)
        --- PASS: kuttl/harness/overrides_openshift-true_spark-3.5.5 (191.30s)
FAIL
ERROR:root:kuttl failed

@razvan razvan moved this from Development: In Progress to Development: Waiting for Review in Stackable Engineering Apr 28, 2025
@razvan
Copy link
Member Author

razvan commented Apr 30, 2025

🟡 CI https://testing.stackable.tech/job/spark-k8s-operator-it-custom/21/

Individual failed tests ran locally successfully.

@NickLarsenNZ NickLarsenNZ self-requested a review May 2, 2025 09:31
@NickLarsenNZ NickLarsenNZ moved this from Development: Waiting for Review to Development: In Review in Stackable Engineering May 2, 2025
NickLarsenNZ
NickLarsenNZ previously approved these changes May 2, 2025
Copy link
Member

@NickLarsenNZ NickLarsenNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, left some nit picks which you can take or leave.

Co-authored-by: Nick <10092581+NickLarsenNZ@users.noreply.github.com>
razvan and others added 4 commits May 2, 2025 12:22
Co-authored-by: Nick <10092581+NickLarsenNZ@users.noreply.github.com>
Co-authored-by: Nick <10092581+NickLarsenNZ@users.noreply.github.com>
@razvan razvan enabled auto-merge May 2, 2025 13:15
Copy link
Member

@NickLarsenNZ NickLarsenNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@razvan razvan added this pull request to the merge queue May 2, 2025
Merged via the queue into main with commit ea260f6 May 2, 2025
17 checks passed
@razvan razvan deleted the feat/listener branch May 2, 2025 13:21
@razvan razvan moved this from Development: In Review to Development: Done in Stackable Engineering May 6, 2025
@lfrancke lfrancke moved this from Development: Done to Acceptance: In Progress in Stackable Engineering May 9, 2025
@lfrancke
Copy link
Member

The typical question for release notes and docs. Do we have/need them?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Acceptance: In Progress
Development

Successfully merging this pull request may close these issues.

Integrate Spark Operator with Listener Operator
3 participants