Skip to content

correct crd docs to be inline with 23.11 release docs #327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 20, 2023
Merged

correct crd docs to be inline with 23.11 release docs #327

merged 2 commits into from
Dec 20, 2023

Conversation

adwk67
Copy link
Member

@adwk67 adwk67 commented Dec 20, 2023 •
edited
Loading

Description

Fixes #326

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes
# Author
- [x] Changes are OpenShift compatible
- [x] Helm chart can be installed and deployed operator works
- [x] Integration tests passed (for non trivial changes)
- [x] Changes need to be "offline" compatible

# Reviewer
- [ ] Code contains useful comments
- [ ] (Integration-)Test cases added
- [ ] Documentation added or updated. Follows the [style guide](https://docs.stackable.tech/home/nightly/contributor/style-guide).
- [ ] Changelog updated
- [ ] Cargo.toml only contains references to git tags (not specific commits or branches)

# Acceptance
- [ ] Feature Tracker has been updated
- [ ] Proper release label has been added

maltesander
maltesander previously approved these changes Dec 20, 2023
View reviewed changes
Copy link
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@adwk67 @maltesander
Update docs/modules/spark-k8s/pages/crd-reference.adoc
d79ed07 
Co-authored-by: Malte Sander <malte.sander.it@gmail.com>
maltesander
maltesander approved these changes Dec 20, 2023
View reviewed changes
Copy link
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@adwk67 adwk67 enabled auto-merge December 20, 2023 12:46
@adwk67 adwk67 added this pull request to the merge queue Dec 20, 2023
Merged via the queue into main with commit cdcadce Dec 20, 2023
@adwk67 adwk67 deleted the fix/update-docs-consistent-with-release-notes branch December 20, 2023 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maltesander maltesander maltesander approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

update spark-k8s operator docs to be consistent with breaking changes in 23.11
2 participants
@adwk67 @maltesander