Skip to content

chore: Add pre-release issue and PR templates #407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 15, 2024

Conversation

Techassi
Copy link
Member

@Techassi Techassi commented Jul 15, 2024

This PR adds two different issue/PR templates:

  • The issue template can be used in this repository to track the Rust toolchain updates
  • The PR template can be used in downstream product operators to track the Rust dependency bumps. This PR template can be linked in the tracking issue located in the "issues" repository.

Issue Template Preview

Pre-Release Rust Toolchain Update for Stackable Release XX.(X)X

Part of https://github.com/stackabletech/issues/TRACKING_ISSUE

Note

During a Stackable release we need to ensure that every product operator uses the latest Rust toolchain (used by us). To keep the toolchain in sync across all our operators, we update the version centrally in this repository.

Update Rust Toolchain

### Tasks in this Repository
- [ ] Update Rust toolchain in the `config/rust.yaml` file.
- [ ] Generate downstream PRs using the ["Generate Downstream PRs"](https://github.com/stackabletech/operator-templating/actions/workflows/generate_prs.yml) action.
- [ ] Merge downstream PRs, see below for more details.

Merge Downstream PRs

Replace the items in the task lists below with the applicable Pull Requests

### Tasks in Downstream Repositories
- [ ] https://github.com/stackabletech/airflow-operator/pulls?q=sort:updated-desc+is:pr+is:open+Update+templated+files
- [ ] https://github.com/stackabletech/commons-operator/pulls?q=sort:updated-desc+is:pr+is:open+Update+templated+files
- [ ] https://github.com/stackabletech/druid-operator/pulls?q=sort:updated-desc+is:pr+is:open+Update+templated+files
- [ ] https://github.com/stackabletech/hbase-operator/pulls?q=sort:updated-desc+is:pr+is:open+Update+templated+files
- [ ] https://github.com/stackabletech/edc-operator/pulls?q=sort:updated-desc+is:pr+is:open+Update+templated+files
- [ ] https://github.com/stackabletech/hdfs-operator/pulls?q=sort:updated-desc+is:pr+is:open+Update+templated+files
- [ ] https://github.com/stackabletech/hello-world-operator/pulls?q=sort:updated-desc+is:pr+is:open+Update+templated+files
- [ ] https://github.com/stackabletech/hive-operator/pulls?q=sort:updated-desc+is:pr+is:open+Update+templated+files
- [ ] https://github.com/stackabletech/kafka-operator/pulls?q=sort:updated-desc+is:pr+is:open+Update+templated+files
- [ ] https://github.com/stackabletech/nifi-operator/pulls?q=sort:updated-desc+is:pr+is:open+Update+templated+files
- [ ] https://github.com/stackabletech/listener-operator/pulls?q=sort:updated-desc+is:pr+is:open+Update+templated+files
- [ ] https://github.com/stackabletech/opa-operator/pulls?q=sort:updated-desc+is:pr+is:open+Update+templated+files
- [ ] https://github.com/stackabletech/secret-operator/pulls?q=sort:updated-desc+is:pr+is:open+Update+templated+files
- [ ] https://github.com/stackabletech/spark-k8s-operator/pulls?q=sort:updated-desc+is:pr+is:open+Update+templated+files
- [ ] https://github.com/stackabletech/superset-operator/pulls?q=sort:updated-desc+is:pr+is:open+Update+templated+files
- [ ] https://github.com/stackabletech/trino-operator/pulls?q=sort:updated-desc+is:pr+is:open+Update+templated+files
- [ ] https://github.com/stackabletech/zookeeper-operator/pulls?q=sort:updated-desc+is:pr+is:open+Update+templated+files

PR Template Preview

Bump Rust Dependencies for Stackable Release XX.(X)X

Part of https://github.com/stackabletech/issues/TRACKING_ISSUE

Note

During a Stackable release we need to update various Rust dependencies before entering the final release period to ensure we run the latest versions of crates. These bumps also include previously updated and released crates from the operator-rs repository.

### Tasks
- [ ] Bump Rust Dependencies, see below for more details.
- [ ] Add changelog entry stating which important crates were bumped (including the version).

Note

The bumping / updating of Rust dependencies is done in multiple steps:

  1. Update the minimum Version in the root Cargo.toml manifest.
  2. Run the cargo update command, which also updates the Cargo.lock file.
  3. Lastly, run make regenerate-nix to update the Cargo.nix file.
### Bump Rust Dependencies
- [ ] Bump `stackable-operator` and friends.
- [ ] Bump `product-version`.
- [ ] Bump all other dependencies.

NickLarsenNZ
NickLarsenNZ previously approved these changes Jul 15, 2024
Copy link
Member

@NickLarsenNZ NickLarsenNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wanted to also mention if we should add a note about pre-commit, but couldn't find an appropriate place, so maybe that's a separate thing.

Techassi and others added 2 commits July 15, 2024 15:11
Co-authored-by: Nick <NickLarsenNZ@users.noreply.github.com>
Copy link
Member

@NickLarsenNZ NickLarsenNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Techassi Techassi added this pull request to the merge queue Jul 15, 2024
Merged via the queue into main with commit f2f4695 Jul 15, 2024
17 checks passed
@Techassi Techassi deleted the chore/add-issue-and-pr-templates branch July 15, 2024 15:15
@Techassi
Copy link
Member Author

Personal reminder: This still needs to be rolled-out in downstream repos.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants