-
-
Notifications
You must be signed in to change notification settings - Fork 15
feat(stackable-versioned): Add support for multiple k8s shortname
arguments
#958
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(stackable-versioned): Add support for multiple k8s shortname
arguments
#958
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice addition 👍
I think we should add this to the macro doc comment / adjust the current one and explain how multiple shortnames can be set.
I copy/pasted from the module docs to keep wrapping new-lines consistent.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice non-breaking change 👍
Docs have been updated as well.
I let you decide if you want to block this PR on @Techassi
Thanks. I will merge it so we can use it on a PR that is blocked by it. |
Description
Part of stackabletech/issues#642.
stackable-versioned: Add support for multiple k8s
shortname
arguments.Definition of Done Checklist