Skip to content

feat(stackable-versioned): Add support for multiple k8s shortname arguments #958

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Feb 14, 2025

Conversation

NickLarsenNZ
Copy link
Member

Description

Part of stackabletech/issues#642.

stackable-versioned: Add support for multiple k8s shortname arguments.

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes
# Author
- [x] Integration tests passed (for non trivial changes)
# Reviewer
- [ ] Code contains useful comments
- [ ] (Integration-)Test cases added
- [ ] Documentation added or updated
- [ ] Changelog updated
- [ ] Cargo.toml only contains references to git tags (not specific commits or branches)
# Acceptance
- [ ] Feature Tracker has been updated
- [ ] Proper release label has been added

@NickLarsenNZ NickLarsenNZ requested a review from xeniape February 12, 2025 12:54
@NickLarsenNZ NickLarsenNZ self-assigned this Feb 12, 2025
@Techassi Techassi self-requested a review February 12, 2025 18:45
Copy link
Member

@Techassi Techassi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice addition 👍

I think we should add this to the macro doc comment / adjust the current one and explain how multiple shortnames can be set.

@NickLarsenNZ
Copy link
Member Author

Very nice addition 👍

I think we should add this to the macro doc comment / adjust the current one and explain how multiple shortnames can be set.

Fixed in 2278075

I also made the k8s argument docs more consistent in 975a65e (see the commit message).

Copy link
Member

@sbernauer sbernauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice non-breaking change 👍
Docs have been updated as well.
I let you decide if you want to block this PR on @Techassi

@NickLarsenNZ
Copy link
Member Author

Nice non-breaking change 👍
Docs have been updated as well.
I let you decide if you want to block this PR on @Techassi

Thanks. I will merge it so we can use it on a PR that is blocked by it.

@NickLarsenNZ NickLarsenNZ dismissed Techassi’s stale review February 14, 2025 10:50

Docs have been fixed

@NickLarsenNZ NickLarsenNZ added this pull request to the merge queue Feb 14, 2025
Merged via the queue into main with commit 0bb3551 Feb 14, 2025
10 checks passed
@NickLarsenNZ NickLarsenNZ deleted the feat/stackable-versioned-multiple-k8s-shortnames branch February 14, 2025 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants