feat(stackable-versioned): Add support for modules #891
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Techassi
changed the title
81 tasks
This separates token generation code to be more modular. Depending on the context, individual parts of the code need to be placed in different locations. Two major refactors are the change of macro input as well as moving module generation out of the struct definition generation. This commit doesn't include changes for enum generation. This will be done in a separate commit.
This commit contains a major rework of most parts of the attribute macro to support attaching it to modules. Most of the previously existing features are already in place. There are only two missing features which will be added in follow-up commits: version specific doc comments and merged CRD YAML support. Because of that, some snapshot tests are failing.
This also adds a test to validate that the relevant code is not generated of the skip option is set.
NickLarsenNZ
previously approved these changes
Nov 22, 2024
crates/stackable-versioned-macros/src/codegen/container/enum.rs
Outdated
Show resolved
Hide resolved
Co-authored-by: Nick <10092581+NickLarsenNZ@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of stackabletech/issues#642
Add support to apply the
#[versioned()]macro to modules to version all contained items at once. Adding this feature required extensive refactoring through out the code.