Skip to content

[Merged by Bors] - Add status field support #571

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 40 commits into from
Closed

[Merged by Bors] - Add status field support #571

wants to merge 40 commits into from

Conversation

razvan
Copy link
Member

@razvan razvan commented Mar 24, 2023 •
edited
Loading

Description

Fixes stackabletech/issues#362

Review Checklist

  • Code contains useful comments
  • (Integration-)Test cases added (or not applicable)
  • Documentation added (or not applicable)
  • Changelog updated (or not applicable)
  • Cargo.toml only contains references to git tags (not specific commits or branches)

Once the review is done, comment bors r+ (or bors merge) to merge. Further information

razvan and others added 23 commits March 14, 2023 15:02
@razvan
added status mod
30191c8
@razvan
wip
c0c36c9
@razvan
wip
5a80e16
@razvan
reset cluster_resources.rs to main version
46ac63d
@maltesander
wip
35fdb88
@maltesander
fix yaml representation and some refactoring
e130737
@maltesander
refactoring
854a283
@razvan
refactor for simplification
867f12c
@razvan
sync sts with daemon sets.
0548543
@razvan
Added clusterconditionset
8e0a1b0
@maltesander
make ClusterConditionSet vector size depend on ClusterConditionType e…
ccd7985 
…ntries
@maltesander
some refactoring
cfea057
@razvan
added one test
26d6b44
@maltesander
removed clones
8788e63
@maltesander
Merge remote-tracking branch 'origin/feat/status' into feat/status
62268eb 
# Conflicts:
#	src/status/mod.rs
@razvan
Use vec! macro to initialize conditions.
3acce6f
@maltesander
refactoring & comments
f20a05e
@maltesander
move status condition definitions to correct mod definition
b2ba70a
@maltesander
wip
eda6d33
@razvan
merge/combine and fix tests.
a2ecfd2
@razvan
Use callback instead of bool parameter.
94aec8d
@razvan
Fix doctest
9fdcd3c
@razvan
update changelog
280d150
@razvan razvan requested a review from a team March 24, 2023 08:25
@razvan razvan mentioned this pull request Mar 24, 2023
Closed
17 tasks
sbernauer
sbernauer reviewed Mar 24, 2023
View reviewed changes
@Maleware
Copy link
Member

LGTM! Nice Job

soenkeliebau
soenkeliebau reviewed Mar 31, 2023
View reviewed changes
Copy link
Member

@soenkeliebau soenkeliebau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left a few random comments throughout.
I will try to run it and test it a bit over the next hour and approve afterwards.

soenkeliebau
soenkeliebau approved these changes Mar 31, 2023
View reviewed changes
Copy link
Member

@soenkeliebau soenkeliebau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have looked through the code and are happy with the changes. Full disclosure, I have no actually run or tested it, but in the interest of time I'll approve this.

@maltesander
Copy link
Member

bors merge

bors bot pushed a commit that referenced this pull request Mar 31, 2023
@maltesander @razvan
Add status field support (#571)
b064f7a 
## Description

Fixes stackabletech/issues#362



Co-authored-by: Razvan-Daniel Mihai <84674+razvan@users.noreply.github.com>
@bors
Copy link
Contributor

bors bot commented Mar 31, 2023

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Add status field support [Merged by Bors] - Add status field support Mar 31, 2023
@bors bors bot closed this Mar 31, 2023
@bors bors bot deleted the feat/status branch March 31, 2023 14:27
@nightkr nightkr mentioned this pull request May 14, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soenkeliebau soenkeliebau soenkeliebau approved these changes

@sbernauer sbernauer Awaiting requested review from sbernauer

@maltesander maltesander Awaiting requested review from maltesander

Assignees

@razvan razvan

@maltesander maltesander

Labels
None yet
Projects
Stackable Engineering
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

operator-rs: Add status field support
5 participants
@razvan @Maleware @maltesander @soenkeliebau @sbernauer