-
-
Notifications
You must be signed in to change notification settings - Fork 16
refactor!: Update telemetry related env vars and CLI args #1009
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NickLarsenNZ
previously approved these changes
Apr 11, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
In a follow up PR we should allow configuring the max_files for the rolling file appender.
Co-authored-by: Nick <10092581+NickLarsenNZ@users.noreply.github.com>
Co-authored-by: Nick <10092581+NickLarsenNZ@users.noreply.github.com>
1e96799
to
26016b8
Compare
NickLarsenNZ
approved these changes
Apr 11, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of stackabletech/issues#639
Updated Environment Variables and CLI Arguments
Console logs
CONSOLE_LOG_DISABLED
(--console-log-disabled
): Disables console logs when set totrue
.CONSOLE_LOG_LEVEL
: Set the log level for the console logs.File logs
FILE_LOG_DIRECTORY
(--file-log-directory
): Enable the file logs and set the file log directory.FILE_LOG_ROTATION_PERIOD
(--file-log-rotation-period
): Set the rotation period of log filesFILE_LOG_LEVEL
: Set the log level for file logsOTEL logs
OTEL_LOG_EXPORTER_ENABLED
(--otel-log-exporter-enabled
): Enable exporting OTEL logsOTEL_LOG_EXPORTER_LEVEL
: Set the log level for OTEL logsOTEL traces
OTEL_TRACE_EXPORTER_ENABLED
(--otel-trace-exporter-enabled
): Enable exporting OTEL tracesOTEL_TRACE_EXPORTER_LEVEL
: Set the log level for OTEL traces