feat: Support regular expressions in attributed_string_type#88
Merged
siegfriedweber merged 7 commits intomainfrom Dec 8, 2025
Merged
feat: Support regular expressions in attributed_string_type#88siegfriedweber merged 7 commits intomainfrom
siegfriedweber merged 7 commits intomainfrom
Conversation
19 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
regexadded to the macroattributed_string_type.patternof the JsonSchema.min_lengthadded to the macroattributed_string_type.min_lengthis set in the JsonSchema.min_lengthandmax_lengthare calculated at compile-time. It is not necessary anymore, e.g. to add(max_length = RFC_1123_SUBDOMAIN_MAX_LENGTH)ifis_rfc_1123_dns_subdomain_nameis set.maxfunction added which works in a const context.is_config_map_keyremoved from the macroattributed_string_typeand replaced with a regular expression.attributed_string_typemoved fromframeworktoframework::macros::attributed_string_type.constantmoved fromframeworktoframework::macros::constant.ConfigMapName, moved fromframeworktoframework::types::kubernetes.OperatorName, moved fromframeworktoframework::types::operator.SecretKeyadded.SecretNameadded.Part of #1
Required for #76
Definition of Done Checklist
Author
Reviewer
Acceptance
type/deprecationlabel & add to the deprecation scheduletype/experimentallabel & add to the experimental features tracker