docs: Document workaround to disable SNI checks #834
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
sbernauer
previously approved these changes
Aug 14, 2025
There was a problem hiding this comment.
LGTM, but we should hold of merging until stackabletech/docker-images#1225 is merged.
Can you please also add a docs: prefix to the PR title? :)
If you have the time I would also be happy about a changelog entry that you can now disable the check via configOverrides (yeah, this is a docker-image thing, but users are not going to read docker-images changelog)
lfrancke
changed the title
|
I thought about that and wasn't sure. |
sbernauer
reviewed
Aug 14, 2025
sbernauer
approved these changes
Aug 14, 2025
sbernauer
moved this from Development: Waiting for Review
to Development: In Review
in Stackable Engineering
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Important
This should only be merged once stackabletech/docker-images#1225 is merged
Document workaround to disable SNI checks.
I took the opportunity to rewrite the entire FAQ entry.
Note
This also contains an unrelated change to fix https://rustsec.org/advisories/RUSTSEC-2025-0047 otherwise the build wouldn't work