-
-
Notifications
You must be signed in to change notification settings - Fork 7
Support Zookeeperless NiFi #775
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…ather than hard-coding it
Moving the CRD changes to RfC. |
Previously, these bits would error when re-executed, causing confusing errors when templating fails.
Moving the CRD changes to voting. |
Sorry, didn't see that it was already RfC and now in voting Sounds good to me. Moving to option is non-breaking. What do we do in cases where it is None, but the NiFi version still requires it? |
In that case NiFi would crash on startup. We can add an explicit check for it.. maybe a bit overkill but if we're keeping 1.x for the relatively long haul then it might make sense? |
I think having a snafu Error like "zookeeper-less election not supported for version {}. It's only supported for NiFi 2.x" would be great! |
Added an error in 4f63520. |
Moving the CRD change to approved. All tests passed in Jenkins except for ldap_nifi-2.2.0_zookeeper-latest-3.9.3_ldap-use-tls-true_openshift-false, but that passed locally. |
Description
Fixes #737.
This makes
spec.clusterConfig.zookeeperConfigMapName
optional, switching to the Kubernetes provider if it is not set. The prose docs mention both options, but the quick start guide ("First steps") sticks to ZooKeeper, since it still also recommends NiFi 1.x.A potential v1alpha2 could change this to something like
But I don't think it's worth the compatibility break for v1alpha1.
Definition of Done Checklist