Skip to content

Update release branch #794

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Nov 27, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,14 @@ All notable changes to this project will be documented in this file.

## [Unreleased]

### Fixed

- BREAKING: Use distinct ServiceAccounts for the Stacklets, so that multiple Stacklets can be
deployed in one namespace. Existing Stacklets will use the newly created ServiceAccounts after
restart ([#793]).

[#793]: https://github.com/stackabletech/kafka-operator/pull/793

## [24.11.0] - 2024-11-18

### Added
Expand Down
8 changes: 4 additions & 4 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

14 changes: 7 additions & 7 deletions Cargo.nix

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ serde = { version = "1.0", features = ["derive"] }
serde_json = "1.0"
serde_yaml = "0.9"
snafu = "0.8"
stackable-operator = { git = "https://github.com/stackabletech/operator-rs.git", tag = "stackable-operator-0.80.0" }
stackable-operator = { git = "https://github.com/stackabletech/operator-rs.git", tag = "stackable-operator-0.82.0" }
strum = { version = "0.26", features = ["derive"] }
tokio = { version = "1.40", features = ["full"] }
tracing = "0.1"
Expand Down
3 changes: 3 additions & 0 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,9 @@ SHELL=/usr/bin/env bash -euo pipefail
render-readme:
scripts/render_readme.sh

render-docs:
scripts/docs_templating.sh

## Docker related targets
docker-build:
docker build --force-rm --build-arg VERSION=${VERSION} -t "${DOCKER_REPO}/${ORGANIZATION}/${OPERATOR_NAME}:${VERSION}-${ARCH}" -f docker/Dockerfile .
Expand Down
6 changes: 3 additions & 3 deletions crate-hashes.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

13 changes: 1 addition & 12 deletions docs/modules/kafka/examples/getting_started/getting_started.sh
Original file line number Diff line number Diff line change
Expand Up @@ -2,18 +2,7 @@
set -euo pipefail

# DO NOT EDIT THE SCRIPT
# Instead, update the j2 template, and regenerate it for dev:
# cat <<EOF | jinja2 --format yaml getting_started.sh.j2 -o getting_started.sh
# helm:
# repo_name: stackable-dev
# repo_url: https://repo.stackable.tech/repository/helm-dev/
# versions:
# commons: 0.0.0-dev
# kafka: 0.0.0-dev
# listener: 0.0.0-dev
# secret: 0.0.0-dev
# zookeeper: 0.0.0-dev
# EOF
# Instead, update the j2 template, and regenerate it for dev with `make render-docs`.

# The getting started guide script
# It uses tagged regions which are included in the documentation
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,18 +2,7 @@
set -euo pipefail

# DO NOT EDIT THE SCRIPT
# Instead, update the j2 template, and regenerate it for dev:
# cat <<EOF | jinja2 --format yaml getting_started.sh.j2 -o getting_started.sh
# helm:
# repo_name: stackable-dev
# repo_url: https://repo.stackable.tech/repository/helm-dev/
# versions:
# commons: 0.0.0-dev
# kafka: 0.0.0-dev
# listener: 0.0.0-dev
# secret: 0.0.0-dev
# zookeeper: 0.0.0-dev
# EOF
# Instead, update the j2 template, and regenerate it for dev with `make render-docs`.

# The getting started guide script
# It uses tagged regions which are included in the documentation
Expand Down
10 changes: 5 additions & 5 deletions rust/operator-binary/src/kafka_controller.rs
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ use stackable_operator::{
core::v1::{
ConfigMap, ConfigMapKeySelector, ConfigMapVolumeSource, ContainerPort, EnvVar,
EnvVarSource, ExecAction, ObjectFieldSelector, PodSpec, Probe, Service,
ServiceSpec, Volume,
ServiceAccount, ServiceSpec, Volume,
},
},
apimachinery::pkg::apis::meta::v1::LabelSelector,
Expand Down Expand Up @@ -524,7 +524,7 @@ pub async fn reconcile_kafka(
.context(BuildRbacResourcesSnafu)?;

let rbac_sa = cluster_resources
.add(client, rbac_sa)
.add(client, rbac_sa.clone())
.await
.context(ApplyServiceAccountSnafu)?;
cluster_resources
Expand Down Expand Up @@ -561,7 +561,7 @@ pub async fn reconcile_kafka(
opa_connect.as_deref(),
&kafka_security,
&merged_config,
&rbac_sa.name_any(),
&rbac_sa,
&client.kubernetes_cluster_info,
)?;
let rg_bootstrap_listener = build_broker_rolegroup_bootstrap_listener(
Expand Down Expand Up @@ -824,7 +824,7 @@ fn build_broker_rolegroup_statefulset(
opa_connect_string: Option<&str>,
kafka_security: &KafkaTlsSecurity,
merged_config: &KafkaConfig,
sa_name: &str,
service_account: &ServiceAccount,
cluster_info: &KubernetesClusterInfo,
) -> Result<StatefulSet> {
let role = kafka.role(kafka_role).context(InternalOperatorSnafu)?;
Expand Down Expand Up @@ -1096,7 +1096,7 @@ fn build_broker_rolegroup_statefulset(
)),
)
.context(AddVolumeSnafu)?
.service_account_name(sa_name)
.service_account_name(service_account.name_any())
.security_context(
PodSecurityContextBuilder::new()
.run_as_user(KAFKA_UID)
Expand Down
Loading