Let secret-operator handle PKCS#12 conversion #598
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nightkr
commented
Jun 22, 2023
Comment on lines
-201
to
-206
| // Copy system truststore to stackable truststore | ||
| args.push(format!("keytool -importkeystore -srckeystore {system_trust_store_dir} -srcstoretype jks -srcstorepass {ssl_store_password} -destkeystore {stackable_tls_server_dir}/truststore.p12 -deststoretype pkcs12 -deststorepass {ssl_store_password} -noprompt", | ||
| system_trust_store_dir = Self::SYSTEM_TRUST_STORE_DIR, | ||
| ssl_store_password = Self::SSL_STORE_PASSWORD, | ||
| stackable_tls_server_dir = Self::STACKABLE_TLS_SERVER_DIR, | ||
| )); |
There was a problem hiding this comment.
Asked about this on Slack (https://stackable-workspace.slack.com/archives/C0312UB3LLE/p1687429824406039). Still not sure about whether this is something we support intentionally or not...
|
Obsolete. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Kafka version of stackabletech/zookeeper-operator#695. Requires stackabletech/secret-operator#286, stackabletech/operator-rs#610, and stackabletech/product-config#88.
Definition of Done Checklist
Once the review is done, comment
bors r+(orbors merge) to merge. Further information