Skip to content

Allow specifying global arguments in conf.py #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 6, 2024
Merged

Allow specifying global arguments in conf.py #41

merged 4 commits into from
Sep 6, 2024

Conversation

lfrancke
Copy link
Member

@lfrancke lfrancke commented Sep 3, 2024

No description provided.

@lfrancke lfrancke self-assigned this Sep 3, 2024
razvan
razvan reviewed Sep 3, 2024
View reviewed changes
Copy link
Member

@razvan razvan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't work for me. We can have a look together tomorrow:

➜  docker-images git:(main) ✗ bake --product airflow=2.9.2 --build-arg tini=foo --organization sandbox --dry 2>&1 | rg -i tini
        "TINI": "0.19.0",

razvan
razvan previously approved these changes Sep 4, 2024
View reviewed changes
Copy link
Member

@razvan razvan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@lfrancke @razvan
Update src/image_tools/args.py
f639a26 
Co-authored-by: Razvan-Daniel Mihai <84674+razvan@users.noreply.github.com>
@lfrancke lfrancke enabled auto-merge September 4, 2024 06:59
@lfrancke lfrancke added this pull request to the merge queue Sep 6, 2024
Merged via the queue into main with commit b0c8f34 Sep 6, 2024
5 checks passed
@lfrancke lfrancke deleted the feat/global-args branch September 6, 2024 11:20
@lfrancke lfrancke mentioned this pull request Sep 11, 2024
Merged
@lfrancke lfrancke mentioned this pull request Oct 2, 2024
Open
26 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@razvan razvan razvan approved these changes

Assignees

@lfrancke lfrancke

Labels
None yet
Projects
Stackable Engineering
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lfrancke @razvan