Skip to content

Dependency updates & spotless run #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Nov 4, 2024
Merged

Dependency updates & spotless run #51

merged 11 commits into from
Nov 4, 2024

Conversation

lfrancke
Copy link
Member

@lfrancke lfrancke commented Nov 3, 2024

Definition of Done Checklist

Note: This builds on top of #50 which should be reviewed and merged first

This updates various dependencies (plugins and normal ones).
One thing of note is that it updates error-prone which requires JDK 17 to build. We can still target Java 11 but the actual JDK executing the build needs to be 17 or later.

It also moves spotless to automatically run at compile time.

Maven version 3.6.3 or up is now required.

# Reviewer
- [ ] Changelog updated
# Acceptance
- [ ] Proper release label has been added

- HTTP_CLIENT is now static and includes a connection timeout
- StackableAuthorizer only constructs a single instance of StackableAccessControlEnforcer
- StackableAccessControlEnforcer does not serialize to JSON twice anymore
- Spotless formatting applied to code
This updates various dependencies (plugins and normal ones).
One thing of note is that it updates error-prone which requires JDK 17 to build. We can still target Java 11 but the actual JDK executing the build needs to be 17 or later.

It also moves spotless to automatically run at compile time.

Maven version 3.6.3 or up is now required.
# Conflicts:
#	.github/workflows/maven.yml
#	CHANGELOG.md
#	pom.xml
@lfrancke lfrancke self-assigned this Nov 3, 2024
Copy link
Member

@sbernauer sbernauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tilt tests passed

@lfrancke lfrancke added this pull request to the merge queue Nov 4, 2024
Merged via the queue into main with commit 8fb154d Nov 4, 2024
8 checks passed
@lfrancke lfrancke deleted the feat/updates branch November 4, 2024 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants