-
Notifications
You must be signed in to change notification settings - Fork 0
Dependency updates & spotless run #51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- HTTP_CLIENT is now static and includes a connection timeout - StackableAuthorizer only constructs a single instance of StackableAccessControlEnforcer - StackableAccessControlEnforcer does not serialize to JSON twice anymore - Spotless formatting applied to code
This updates various dependencies (plugins and normal ones). One thing of note is that it updates error-prone which requires JDK 17 to build. We can still target Java 11 but the actual JDK executing the build needs to be 17 or later. It also moves spotless to automatically run at compile time. Maven version 3.6.3 or up is now required.
# Conflicts: # .github/workflows/maven.yml # CHANGELOG.md # pom.xml
# Conflicts: # CHANGELOG.md # pom.xml
sbernauer
approved these changes
Nov 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, tilt tests passed
This was referenced Nov 4, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Definition of Done Checklist
Note: This builds on top of #50 which should be reviewed and merged first
This updates various dependencies (plugins and normal ones).
One thing of note is that it updates error-prone which requires JDK 17 to build. We can still target Java 11 but the actual JDK executing the build needs to be 17 or later.
It also moves spotless to automatically run at compile time.
Maven version 3.6.3 or up is now required.