Skip to content

feat: Introduce maven profile to build against Hadoop 3.3.4, 3.3.6 or 3.4.0 #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jul 4, 2024
Merged

feat: Introduce maven profile to build against Hadoop 3.3.4, 3.3.6 or 3.4.0 #29

merged 8 commits into from
Jul 4, 2024

Conversation

sbernauer
Copy link
Member

Description

Please add a description here. This will become the commit message of the merge request later.

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes
# Reviewer
- [ ] Code contains useful comments
- [ ] (Integration-)Test cases added
- [ ] Documentation added or updated
- [ ] Changelog updated

# Acceptance
- [ ] Proper release label has been added

@sbernauer sbernauer changed the title feat: Introduce maven profile to build against Hadoop 3.3 or 3.4 feat: Introduce maven profile to build against Hadoop 3.3.6 or 3.4.0 Jul 4, 2024
@sbernauer sbernauer requested a review from lfrancke July 4, 2024 12:59
@sbernauer sbernauer self-assigned this Jul 4, 2024
@sbernauer sbernauer requested a review from labrenbe July 4, 2024 13:00
@sbernauer sbernauer changed the title feat: Introduce maven profile to build against Hadoop 3.3.6 or 3.4.0 feat: Introduce maven profile to build against Hadoop 3.3.4, 3.3.6 or 3.4.0 Jul 4, 2024
labrenbe
labrenbe previously approved these changes Jul 4, 2024
View reviewed changes
Copy link
Member

@labrenbe labrenbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sbernauer sbernauer enabled auto-merge July 4, 2024 13:11
labrenbe
labrenbe previously approved these changes Jul 4, 2024
View reviewed changes
Copy link
Member

@labrenbe labrenbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sbernauer sbernauer added this pull request to the merge queue Jul 4, 2024
@sbernauer sbernauer removed this pull request from the merge queue due to a manual request Jul 4, 2024
labrenbe
labrenbe previously approved these changes Jul 4, 2024
View reviewed changes
Copy link
Member

@labrenbe labrenbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sbernauer sbernauer added this pull request to the merge queue Jul 4, 2024
@sbernauer sbernauer removed this pull request from the merge queue due to a manual request Jul 4, 2024
@sbernauer
Revert "Release 0.3.0"
3532f31 
This reverts commit 73bb092.
@sbernauer sbernauer enabled auto-merge July 4, 2024 13:15
labrenbe
labrenbe approved these changes Jul 4, 2024
View reviewed changes
Copy link
Member

@labrenbe labrenbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sbernauer sbernauer added this pull request to the merge queue Jul 4, 2024
Merged via the queue into main with commit 0a0aa37 Jul 4, 2024
13 checks passed
@sbernauer sbernauer deleted the feat/hadoop-3.4 branch July 4, 2024 13:16
@lfrancke
Copy link
Member

lfrancke commented Jul 4, 2024

It's too late now but you can look at the Druid OPA Authorizer how this can be modeled
https://github.com/stackabletech/druid-opa-authorizer

@sbernauer
Copy link
Member Author

This looks exactly the same way I did it 😅 I assume you mentioned this for context, and not because you found a difference or dislike the current state?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@labrenbe labrenbe labrenbe approved these changes

@lfrancke lfrancke Awaiting requested review from lfrancke

Assignees

@sbernauer sbernauer

Labels
None yet
Projects
Stackable Engineering
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sbernauer @lfrancke @labrenbe