Skip to content

feat: Add topology-provider #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 4, 2024
Merged

feat: Add topology-provider #28

merged 4 commits into from
Jul 4, 2024

Conversation

sbernauer
Copy link
Member

@sbernauer sbernauer commented Jul 3, 2024 •
edited by adwk67
Loading

Description

Please add a description here. This will become the commit message of the merge request later.

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes
# Reviewer
- [x] Code contains useful comments
- [ ] (Integration-)Test cases added
- [x] Documentation added or updated
- [x] Changelog updated

# Acceptance
- [ ] Proper release label has been added

@sbernauer sbernauer self-assigned this Jul 3, 2024
@sbernauer sbernauer requested a review from lfrancke July 3, 2024 13:42
adwk67
adwk67 approved these changes Jul 3, 2024
View reviewed changes
Copy link
Member

@adwk67 adwk67 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sbernauer sbernauer added this pull request to the merge queue Jul 4, 2024
Merged via the queue into main with commit f1836b8 Jul 4, 2024
11 of 13 checks passed
@sbernauer sbernauer deleted the feat/add-topology-provider branch July 4, 2024 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adwk67 adwk67 adwk67 approved these changes

@lfrancke lfrancke Awaiting requested review from lfrancke

Assignees

@sbernauer sbernauer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sbernauer @adwk67