Skip to content

chore: remove 2.4 support (including JMX exporter) #672

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

razvan
Copy link
Member

@razvan razvan commented Jun 16, 2025

Description

Part of: stackabletech/issues#735

The product image has removed the JMX exporter jar already.

🟢 CI https://testing.stackable.tech/view/02%20Operator%20Tests%20(custom)/job/hbase-operator-it-custom/56/

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

  • Changes are OpenShift compatible
  • CRD changes approved
  • CRD documentation for all fields, following the style guide.
  • Helm chart can be installed and deployed operator works
  • Integration tests passed (for non trivial changes)
  • Changes need to be "offline" compatible
  • Links to generated (nightly) docs added
  • Release note snippet added

Reviewer

  • Code contains useful comments
  • Code contains useful logging statements
  • (Integration-)Test cases added
  • Documentation added or updated. Follows the style guide.
  • Changelog updated
  • Cargo.toml only contains references to git tags (not specific commits or branches)

Acceptance

  • Feature Tracker has been updated
  • Proper release label has been added
  • Links to generated (nightly) docs added
  • Release note snippet added
  • Add type/deprecation label & add to the deprecation schedule
  • Add type/experimental label & add to the experimental features tracker

@razvan razvan self-assigned this Jun 16, 2025
@razvan
Copy link
Member Author

razvan commented Jun 17, 2025

Release Note

Starting with this release, support for HBase 2.4.x has been removed. This includes metrics exposed via the JMX exporter. All supported HBase versions expose metrics via the built in Prometheus servlet.

@razvan razvan moved this to Development: Waiting for Review in Stackable Engineering Jun 17, 2025
@razvan razvan requested a review from a team June 17, 2025 06:53
@razvan razvan added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Jun 17, 2025
Copy link
Member

@xeniape xeniape left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just left a question

Also some things not part of the changed files:

  • kuttl test opa/30-install-hbase.yaml.j2 line 32 contains some HBase 2.4 log4j.properties probably no longer needed
  • monitoring documentation mentions "The old URL http://<master-service>:9100 is still available for HBase 2.4.", this can also be removed

/// Hbase versions 2.6.* will have two ports for each role. The metrics are available over the
/// UI port.
pub fn ports(&self, role: &HbaseRole, hbase_version: &str) -> Vec<(String, u16)> {
let result_without_metric_port: Vec<(String, u16)> = match role {
pub fn ports(&self, role: &HbaseRole, _hbase_version: &str) -> Vec<(String, u16)> {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't the _hbase_version argument be just removed?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes

@xeniape
Copy link
Member

xeniape commented Jun 19, 2025

--- FAIL: kuttl (1959.43s)
    --- FAIL: kuttl/harness (0.00s)
        --- PASS: kuttl/harness/smoke_hbase-2.6.2_hdfs-3.4.1_zookeeper-3.9.3_listener-class-cluster-internal_openshift-false (1359.96s)
        --- FAIL: kuttl/harness/smoke_hbase-2.6.1_hdfs-3.4.1_zookeeper-3.9.3_listener-class-cluster-internal_openshift-false (1360.72s)
        --- PASS: kuttl/harness/smoke_hbase-2.6.1_hdfs-3.4.1_zookeeper-3.9.3_listener-class-external-unstable_openshift-false (298.62s)
        --- FAIL: kuttl/harness/smoke_hbase-2.6.2_hdfs-3.4.1_zookeeper-3.9.3_listener-class-external-unstable_openshift-false (598.70s)
FAIL

Two of the tests are failing for me. The first one with

Create a table with compression=GZ
 ==============
command failure, skipping 1 additional commands

And the second one with

AssertionError: Metric 'table_requests_namespace_hbase_table_meta_table_write_query_per_second_count' not found for regionserver

@razvan
Copy link
Member Author

razvan commented Jun 19, 2025

AssertionError: Metric 'table_requests_namespace_hbase_table_meta_table_write_query_per_second_count' not found for regionserver

Thanks. I updated the test.

--- PASS: kuttl (688.14s)
    --- PASS: kuttl/harness (0.00s)
        --- PASS: kuttl/harness/smoke_hbase-2.6.2_hdfs-3.4.1_zookeeper-3.9.3_listener-class-cluster-internal_openshift-false (387.37s)
        --- PASS: kuttl/harness/smoke_hbase-2.6.1_hdfs-3.4.1_zookeeper-3.9.3_listener-class-cluster-internal_openshift-false (387.52s)
        --- PASS: kuttl/harness/smoke_hbase-2.6.2_hdfs-3.4.1_zookeeper-3.9.3_listener-class-external-unstable_openshift-false (298.98s)
        --- PASS: kuttl/harness/smoke_hbase-2.6.1_hdfs-3.4.1_zookeeper-3.9.3_listener-class-external-unstable_openshift-false (300.16s)
PASS

@razvan razvan requested a review from xeniape June 19, 2025 11:06
@razvan razvan moved this from Development: Waiting for Review to Development: In Review in Stackable Engineering Jun 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
Status: Development: In Review
Development

Successfully merging this pull request may close these issues.

2 participants