-
-
Notifications
You must be signed in to change notification settings - Fork 4
chore: remove 2.4 support (including JMX exporter) #672
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Release NoteStarting with this release, support for HBase 2.4.x has been removed. This includes metrics exposed via the JMX exporter. All supported HBase versions expose metrics via the built in Prometheus servlet. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just left a question
Also some things not part of the changed files:
- kuttl test
opa/30-install-hbase.yaml.j2
line 32 contains some HBase 2.4 log4j.properties probably no longer needed - monitoring documentation mentions "The old URL
http://<master-service>:9100
is still available for HBase 2.4.", this can also be removed
rust/operator-binary/src/crd/mod.rs
Outdated
/// Hbase versions 2.6.* will have two ports for each role. The metrics are available over the | ||
/// UI port. | ||
pub fn ports(&self, role: &HbaseRole, hbase_version: &str) -> Vec<(String, u16)> { | ||
let result_without_metric_port: Vec<(String, u16)> = match role { | ||
pub fn ports(&self, role: &HbaseRole, _hbase_version: &str) -> Vec<(String, u16)> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can't the _hbase_version
argument be just removed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two of the tests are failing for me. The first one with
And the second one with
|
Thanks. I updated the test.
|
Description
Part of: stackabletech/issues#735
The product image has removed the JMX exporter jar already.
🟢 CI https://testing.stackable.tech/view/02%20Operator%20Tests%20(custom)/job/hbase-operator-it-custom/56/
Definition of Done Checklist
Author
Reviewer
Acceptance
type/deprecation
label & add to the deprecation scheduletype/experimental
label & add to the experimental features tracker