Skip to content

test(snapshot-export): Fix the test script #665

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 28, 2025
Merged

Conversation

siegfriedweber
Copy link
Member

Description

In #659, comments were added within the export command which broke it. Now, there are separate exports, increasing the changeability.

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

  • Integration tests passed locally

Reviewer

  • Code contains useful comments
  • Code contains useful logging statements
  • (Integration-)Test cases added
  • Documentation added or updated. Follows the style guide.
  • Changelog updated
  • Cargo.toml only contains references to git tags (not specific commits or branches)

Acceptance

  • Feature Tracker has been updated
  • Proper release label has been added
  • Roadmap has been updated

@siegfriedweber siegfriedweber requested a review from a team May 28, 2025 07:28
@siegfriedweber siegfriedweber self-assigned this May 28, 2025
@siegfriedweber siegfriedweber moved this to Development: Waiting for Review in Stackable Engineering May 28, 2025
@lfrancke lfrancke moved this from Development: Waiting for Review to Development: Done in Stackable Engineering May 28, 2025
@lfrancke lfrancke enabled auto-merge May 28, 2025 07:40
@lfrancke lfrancke added this pull request to the merge queue May 28, 2025
Merged via the queue into main with commit 00b9a0f May 28, 2025
17 checks passed
@lfrancke lfrancke deleted the test/fix-snapshot-export branch May 28, 2025 07:46
@lfrancke lfrancke moved this from Development: Done to Done in Stackable Engineering May 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

2 participants