Skip to content

ADR: Listener Operator #256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 35 commits into from
Sep 12, 2022
Merged

ADR: Listener Operator #256

merged 35 commits into from
Sep 12, 2022

Conversation

fhennig
Copy link
Contributor

@fhennig fhennig commented Aug 23, 2022 •
edited
Loading

resolves #265

@fhennig fhennig mentioned this pull request Aug 23, 2022
Closed
@fhennig fhennig self-assigned this Aug 23, 2022
@nightkr nightkr mentioned this pull request Aug 24, 2022
Closed
@fhennig fhennig marked this pull request as ready for review August 25, 2022 07:28
@fhennig fhennig requested a review from nightkr August 25, 2022 07:28
nightkr
nightkr reviewed Aug 25, 2022
View reviewed changes
nightkr
nightkr reviewed Sep 1, 2022
View reviewed changes
Copy link
Member

@nightkr nightkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it time to do the Listener Operator rebrand?

@fhennig fhennig requested a review from nightkr September 1, 2022 09:10
@sbernauer sbernauer changed the title ADR: LoadBalancer Operator ADR: Listener Operator Sep 5, 2022
vsupalov
vsupalov reviewed Sep 5, 2022
View reviewed changes
Copy link
Contributor

@vsupalov vsupalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was a pleasure reading this ADR. A great addition to help understand the actual implementation. I hope the comments will help to make it even better to understand for people who are not in-depth familiar with the details of the problem.

razvan
razvan previously approved these changes Sep 7, 2022
View reviewed changes
nightkr
nightkr previously approved these changes Sep 8, 2022
View reviewed changes
Copy link
Member

@nightkr nightkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor clarifications, but looks good overall

@fhennig fhennig dismissed stale reviews from nightkr and razvan via 5f7d844 September 8, 2022 09:59
fhennig and others added 5 commits September 8, 2022 11:59
@fhennig @nightkr
Update modules/contributor/pages/adr/ADR024-out-of-cluster_access.adoc
5f7d844 
Co-authored-by: Teo Klestrup Röijezon <teo@nullable.se>
@fhennig @nightkr
Update modules/contributor/pages/adr/ADR024-out-of-cluster_access.adoc
0af83dd 
Co-authored-by: Teo Klestrup Röijezon <teo@nullable.se>
@fhennig @nightkr
Update modules/contributor/pages/adr/ADR024-out-of-cluster_access.adoc
7d45d32 
Co-authored-by: Teo Klestrup Röijezon <teo@nullable.se>
@fhennig @nightkr
Update modules/contributor/pages/adr/ADR024-out-of-cluster_access.adoc
03f2b23 
Co-authored-by: Teo Klestrup Röijezon <teo@nullable.se>
@fhennig
Some changes
d9c7fc4
@fhennig fhennig requested a review from nightkr September 8, 2022 11:39
nightkr
nightkr previously approved these changes Sep 8, 2022
View reviewed changes
@fhennig @nightkr
Update modules/contributor/pages/adr/ADR024-out-of-cluster_access.adoc
85cacac 
Co-authored-by: Teo Klestrup Röijezon <teo@nullable.se>
nightkr
nightkr previously approved these changes Sep 8, 2022
View reviewed changes
Copy link
Member

@nightkr nightkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@fhennig
Copy link
Contributor Author

fhennig commented Sep 8, 2022

bors merge

@bors
Copy link

bors bot commented Sep 8, 2022

Configuration problem:
bors.toml: not found

@fhennig fhennig merged commit 3558119 into main Sep 12, 2022
@fhennig fhennig deleted the lb-operator-adr branch September 12, 2022 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soenkeliebau soenkeliebau soenkeliebau left review comments

@nightkr nightkr nightkr approved these changes

@razvan razvan razvan left review comments

@vsupalov vsupalov vsupalov left review comments

Assignees

@soenkeliebau soenkeliebau

Labels
None yet
Projects
Stackable Engineering
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ADR for connecting to "identity-ful" services (listener-operator)
5 participants
@fhennig @razvan @nightkr @soenkeliebau @vsupalov