-
-
Notifications
You must be signed in to change notification settings - Fork 7
Make uid/gid configurable & change group of files - part 2 #890
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This is a follow-up for #849 and includes: - The missing bits for Hive - Kafka
- Kafka Testing Tools - KCat - NiFi - Omid
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I assume the images build locally.
Co-authored-by: Nick <10092581+NickLarsenNZ@users.noreply.github.com>
And to answer your question: Yes, it builds locally and I did run all tests (see the issue description) and it all looks good. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* Make uid/gid configurable & change group of files This is a follow-up for #849 and includes: - The missing bits for Hive - Kafka * More tools now migrated but not tested yet: - Kafka Testing Tools - KCat - NiFi - Omid * - OPA - Spark (WIP) * Adds Spark and a changelog entry * Update CHANGELOG.md Co-authored-by: Nick <10092581+NickLarsenNZ@users.noreply.github.com> * Update comment --------- Co-authored-by: Nick <10092581+NickLarsenNZ@users.noreply.github.com>
Description
Make uid/gid configurable & change group of files.
This is a follow-up for #849 (please check there for details).
This includes ( ✔️ means all tests have been run)
There are still a few tools missing and they'll come in a follow-up PR
Definition of Done Checklist
TIP: Running integration tests with a new product image
The image can be built and uploaded to the kind cluster with the following commands:
See the output of
bake
to retrieve the image tag for<image-tagged-with-the-major-version>
.