Use our build-repo to cache NPM dependencies #1219
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lfrancke
moved this from Development: In Progress
to Development: Waiting for Review
in Stackable Engineering
maltesander
moved this from Development: Waiting for Review
to Development: In Review
in Stackable Engineering
lfrancke
moved this from Development: In Review
to Development: Done
in Stackable Engineering
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We're already using our mirror to cache Maven dependencies.
This uses the same mirror for NPM dependencies.
I tried building all of these and they worked:
Definition of Done Checklist
How I tested this
I did apply the patch and built all images in all versions. They all succeeded so I'm sure that things have not gotten worse. At the same time I tailed the logs for our build-repo server and saw accesses to the NPM mirror. As we're not using that mirror anywhere else I'm fairly certain that these requests must be coming from me.
As a side-effect I also built a spike which introduces a proxy in our build process which can intercept these calls. The branch is available here https://github.com/stackabletech/docker-images/tree/feat/proxy but I did not test it with this yet. That's for the future. This is purely informational and this branch is NOT READY for use.
After these tests I'm convinced that the mirroring will work for at least some projects and it does not break any of them.