Skip to content

chore(krb5-testing-tools): Rename image #1167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

NickLarsenNZ
Copy link
Member

@NickLarsenNZ NickLarsenNZ commented Jun 13, 2025

The image is not part of the SDP platform, so I recommend we move it to the correct Harbor project, and rename the image so indicate its usage.

Caution

Update image references in ad-init and hdfs-topology-provider. Be sure to use Harbor and the correct project (stackable instead of sdp).

@NickLarsenNZ
Copy link
Member Author

NickLarsenNZ commented Jun 13, 2025

Note, there are other images that should also be move to the stackable project in Harbor:

  • kafka-testing-tools
  • testing-tools
  • maybe trino-cli

@NickLarsenNZ NickLarsenNZ changed the title chore(krb5): Update readme chore(krb5-testing-tools): Rename image Jun 13, 2025
@NickLarsenNZ
Copy link
Member Author

The image builds:

 => => exporting layers                                                                                                                                                                                                                                            1.2s
 => => writing image sha256:663584d2fea34c2aa6cce1052521b1eab2bab59118700d63ef521bd59f9c6519                                                                                                                                                                       0.0s 
 => => naming to oci.stackable.tech/sdp/krb5-testing-tools:1.21.1-stackable0.0.0-dev

@nightkr
Copy link
Member

nightkr commented Jun 13, 2025

krb5-testing-server maybe? Traditionally we've reserved -tools for "toolbox images" rather than daemons.

@NickLarsenNZ
Copy link
Member Author

NickLarsenNZ commented Jun 13, 2025

krb5-testing-server maybe? Traditionally we've reserved -tools for "toolbox images" rather than daemons.

I was going to call it -server until I saw it being used as a client (and not server) in a container.

https://github.com/stackabletech/hdfs-topology-provider/blob/3a865217f134f816f915c2266ef1a233c0b7e753/test/stack/01-install-krb5-kdc.yaml#L80-L89

I don't mind though.

@nightkr
Copy link
Member

nightkr commented Jun 13, 2025

Ah, right. For some reason I thought we set CMD. We don't, so -tools should be fine after all ("server is one role it can take, but not the default").

@NickLarsenNZ NickLarsenNZ self-assigned this Jun 13, 2025
@NickLarsenNZ NickLarsenNZ marked this pull request as ready for review June 13, 2025 11:18
@NickLarsenNZ NickLarsenNZ moved this to Development: Waiting for Review in Stackable Engineering Jun 13, 2025
@NickLarsenNZ
Copy link
Member Author

NickLarsenNZ commented Jun 13, 2025

I'll raise the two PRs (ad-init, hdfs-topology-provider) before merging this

@NickLarsenNZ NickLarsenNZ requested review from nightkr and lfrancke June 13, 2025 13:43
# krb5-testing-tools

> [!CAUTION]
> This image is only intended for Stackable-internal tests.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We use it in demos too, right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Development: Waiting for Review
Development

Successfully merging this pull request may close these issues.

2 participants