Skip to content

Conversation

Techassi
Copy link
Member

@Techassi Techassi commented Apr 14, 2025

This adds a reusable image build workflow which encapsulates all required steps to build a (product) image into a single file. This workflow can then be used by each product / tool which massively reduces duplicated code.

This PR also removes the no longer supported build-cache-password input from the build-product-image action (caused failing builds due to cache corruption).

@Techassi Techassi self-assigned this Apr 14, 2025
@Techassi Techassi marked this pull request as ready for review April 14, 2025 10:34
@Techassi Techassi moved this to Development: Waiting for Review in Stackable Engineering Apr 14, 2025
@Techassi Techassi requested a review from NickLarsenNZ April 14, 2025 10:35
@NickLarsenNZ NickLarsenNZ moved this from Development: Waiting for Review to Development: In Review in Stackable Engineering Apr 14, 2025
NickLarsenNZ
NickLarsenNZ previously approved these changes Apr 14, 2025
Copy link
Member

@NickLarsenNZ NickLarsenNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@NickLarsenNZ NickLarsenNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Techassi Techassi added this pull request to the merge queue Apr 14, 2025
@Techassi Techassi moved this from Development: In Review to Development: Done in Stackable Engineering Apr 14, 2025
Merged via the queue into main with commit 54ce0e8 Apr 14, 2025
3 checks passed
@Techassi Techassi deleted the ci/reusable-workflow branch April 14, 2025 14:32
@lfrancke lfrancke moved this from Development: Done to Done in Stackable Engineering Apr 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants