Skip to content

feat: adjust styling to match stackable website #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 8, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 0 additions & 15 deletions js/nav.js

This file was deleted.

3 changes: 1 addition & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,7 @@
"build:doc": "esbuild js/doc.js --bundle --minify --sourcemap --format=esm --outfile=static/js/doc.js",
"build:home": "esbuild js/home.js --bundle --minify --sourcemap --outfile=static/js/home.js",
"build:org": "esbuild js/org.js --bundle --minify --sourcemap --outfile=static/js/org.js",
"build:nav": "esbuild js/nav.js --bundle --minify --sourcemap --outfile=static/js/nav.js",
"build": "pnpm build:nav && pnpm build:home && pnpm build:org && pnpm build:doc"
"build": "pnpm build:home && pnpm build:org && pnpm build:doc"
},
"devDependencies": {
"esbuild": "^0.23.1",
Expand Down
20 changes: 16 additions & 4 deletions static/css/root.css
Original file line number Diff line number Diff line change
Expand Up @@ -45,8 +45,8 @@ code {
}

.nav-link:hover {
color: var(--navbar-font-color);
text-decoration: underline;
color: var(--navbar-font-color-hover);
text-decoration: none;
}

.nav-item.active>.nav-link,
Expand Down Expand Up @@ -86,14 +86,26 @@ code {
visibility: hidden;
}

#operator-menu.active {
#operator-menu-button:hover + #operator-menu,
#operator-menu:hover {
visibility: visible;
}

.dropdown-menu {
top: 60px;
top: var(--navbar-height);
border-radius: 0;
border: none;
padding: 0px;
}

.dropdown-item {
color: var(--navbar-font-color);
background-color: var(--navbar-background);
}
.dropdown-item:hover {
text-decoration: none;
color: var(--navbar-font-color-hover);
background-color: var(--navbar-background-hover);
}

/* copy tooltip */
Expand Down
2 changes: 2 additions & 0 deletions static/css/vars.css
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,9 @@
--header-font-family-weight: 600; /* semi-bold */
/* navbar */
--navbar-background: var(--color-white);
--navbar-background-hover: var(--color-background2);
--navbar-font-color: var(--color-text);
--navbar-font-color-hover: var(--color-brand-primary);
/* footer */
--footer-background: var(--color-white);
--footer-font-color: var(--color-text);
Expand Down
333 changes: 67 additions & 266 deletions static/js/doc.js

Large diffs are not rendered by default.

8 changes: 4 additions & 4 deletions static/js/doc.js.map

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion static/js/home.js.map

Large diffs are not rendered by default.

2 changes: 0 additions & 2 deletions static/js/nav.js

This file was deleted.

7 changes: 0 additions & 7 deletions static/js/nav.js.map

This file was deleted.

2 changes: 1 addition & 1 deletion static/js/org.js.map

Large diffs are not rendered by default.

8 changes: 2 additions & 6 deletions template/_navbar.html
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,7 @@
<a href="/" class="nav-link">CRD Documentation</a>
</li>
<li class="nav-item">
<a class="nav-link" id="operator-menu-button" onclick="toggleMenu()">
Operators
<i class="fa fa-angle-down ml-5" aria-hidden="true"></i> <!-- ml-5= margin-left: 0.5rem (5px) -->
</a>
<a class="nav-link" id="operator-menu-button">Operators</a>
<div class="dropdown-menu dropdown-menu-right" id="operator-menu" aria-labelledby="operator-menu-button">
<a class="dropdown-item" href="/airflow-operator">Airflow Operator</a>
<a class="dropdown-item" href="/druid-operator">Druid Operator</a>
Expand All @@ -32,5 +29,4 @@
</li>
</ul>
</div>
</nav>
<script src="/static/js/nav.js"></script>
</nav>