fix: ensure isformat does not truncate 0Z #535
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YuriZmytrakov
force-pushed
the
CAT-1611
branch
from
6bafb52 to
5f56e5c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR fixes
.0Zmilliseconds being truncated byisformat, causing items outside the expected datetime range to be returned. The apply_filter_datetime function was updated to preserve milliseconds when filtering, ensuring that only items exactly within the specified datetime range are included.Example
2023-01-09T13:39:39.0Zreturned item2023-01-09T13:39:39.024Zwhich is not within the specified range, but was returned because .0Z was truncated to 2023-01-09T13:39:39Z.After the fix, queries respect millisecond precision, and only items strictly within the specified range are returned.
PR Checklist:
pre-commit run --all-files)make test)