feat: retry with back-off logic for Redis #528
+186
−40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gomez324
reviewed
Nov 14, 2025
| return v | ||
|
|
||
|
|
||
| class RedisRetrySettings(BaseSettings): |
Collaborator
There was a problem hiding this comment.
You can create a parent class that both RedisSentinelSettings and RedisSettings will inherit from. This way we won't need to keep another class in memory. You can also move the common elements from the child classes to the parent class
Gomez324
requested changes
Nov 14, 2025
Collaborator
Gomez324
left a comment
Gomez324
left a comment
There was a problem hiding this comment.
I just have one suggestion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR improves Redis functionality by adding a retry wrapper with back-off mechanism resulting in maintaining connections that would otherwise error due to temporary failures.
PR Checklist:
pre-commit run --all-files)make test)