Skip to content

Ensure consistent validation #368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 7, 2025
Merged

Ensure consistent validation #368

merged 6 commits into from
May 7, 2025

Conversation

jonhealy1
Copy link
Collaborator

@jonhealy1 jonhealy1 commented May 6, 2025

Related Issue(s):

Description:

  • Bulk insertion via BulkTransactionsClient now strictly validates all STAC Items using the Pydantic model before insertion. Any invalid item will immediately raise a ValidationError, ensuring consistent validation with single-item inserts and preventing invalid STAC Items from being stored. This validation is enforced regardless of the RAISE_ON_BULK_ERROR setting.
  • Refactored create_item and update_item methods to share unified logic, ensuring consistent conflict detection, validation, and database operations.

PR Checklist:

  • Code is formatted and linted (run pre-commit run --all-files)
  • Tests pass (run make test)
  • Documentation has been updated to reflect changes, if applicable
  • Changes are added to the changelog

@jonhealy1 jonhealy1 marked this pull request as ready for review May 6, 2025 15:56
Copy link
Collaborator

@jamesfisher-geo jamesfisher-geo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Just a couple small questions

@jonhealy1 jonhealy1 requested a review from jamesfisher-geo May 7, 2025 03:07
@jonhealy1 jonhealy1 merged commit b8d6c38 into main May 7, 2025
15 checks passed
@jonhealy1 jonhealy1 deleted the validation-fix branch May 7, 2025 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants