Update stac-fastapi parent libraries to 5.1.1 #354

jonhealy1 · 2025-04-12T12:30:00Z

Related Issue(s):

Description:

PR Checklist:

Code is formatted and linted (run pre-commit run --all-files)
Tests pass (run make test)
Documentation has been updated to reflect changes, if applicable
Changes are added to the changelog

rhysrevans3 · 2025-04-15T15:55:24Z

stac_fastapi/core/stac_fastapi/core/core.py

+    def _format_datetime_range(self, date_str: str) -> str:
        """
-        Convert a tuple of datetime objects or None into a formatted string for API requests.
+        Convert a datetime range into a formatted string.

        Args:
-            date_tuple (tuple): A tuple containing two elements, each can be a datetime object or None.
+            date_tuple (str): A string containing two datetime values separated by a '/'.

        Returns:
            str: A string formatted as 'YYYY-MM-DDTHH:MM:SS.sssZ/YYYY-MM-DDTHH:MM:SS.sssZ', with '..' used if any element is None.
        """
-
-        def format_datetime(dt):
-            """Format a single datetime object to the ISO8601 extended format with 'Z'."""
-            return dt.strftime("%Y-%m-%dT%H:%M:%S.%f")[:-3] + "Z" if dt else ".."
-
-        start, end = date_tuple
-        return f"{format_datetime(start)}/{format_datetime(end)}"
+        start, end = date_str.split("/")
+        start = start.replace("+01:00", "Z") if start else ".."
+        end = end.replace("+01:00", "Z") if end else ".."
+        return f"{start}/{end}"


Is this change caused by a change to stac-fastapi? I don't think we want to replace +01:00 explicitly as it could be a different timezone. Something like this would work

from datetime import datetime, timezone start = datetime.strptime(start, "%Y-%m-%dT%H:%M:%S%z").astimezone(timezone.utc).strftime('%Y-%m-%dT%H:%M:%SZ')

There's also some code in stac-fastapi that could help https://github.com/stac-utils/stac-fastapi/blob/main/stac_fastapi/types/stac_fastapi/types/rfc3339.py

Nice catch here. This is a change from stac-fastapi where the get search method now accepts a string as input instead of a tuple. Let me know what you think of the new change. I was having troubles going from string to datetime object back to string and then I was wondering if it's worth it.

The changes look good! One question though if a user searches for a datetime that includes a timezone like 2001-01-01T01:01:01+01:00 should the search actually be on 2001-01-01T00:01:01Z or maybe add one hour? Or is it okay just to strip that off?

If it does changes the search I think it's better to let datetime handle the timezones. We could use rfc3339_str_to_datetime from stac-fastapi to handle the string to datetime conversion. As the Item search spec states that datetimes should be formatted to that standard.

from stac_fastapi.types.rfc3339 import rfc3339_str_to_datetime from datetime import timezone start = start if start == '..' else rfc3339_str_to_datetime(start).astimezone(timezone.utc).strftime('%Y-%m-%dT%H:%M:%SZ')

Hi. I have updated the code. I also had to update a test - let me know if it looks ok. Thanks!

Look great!

rhysrevans3 · 2025-04-16T12:34:56Z

stac_fastapi/tests/resources/test_item.py

-    tzinfo = timezone(timedelta(hours=1))
    test_item = load_test_data("test_item.json")
    item_date = rfc3339_str_to_datetime(test_item["properties"]["datetime"])
    item_date_before = item_date - timedelta(seconds=1)
-    item_date_before = item_date_before.replace(tzinfo=tzinfo)
    item_date_after = item_date + timedelta(seconds=1)
-    item_date_after = item_date_after.replace(tzinfo=tzinfo)


If we wanted to keep the timezone info in the test we could use astimezone instead of replace. But I think it's okay to leave it out.

tzinfo = timezone(timedelta(hours=1)) test_item = load_test_data("test_item.json") item_date = rfc3339_str_to_datetime(test_item["properties"]["datetime"]) item_date_before = item_date - timedelta(seconds=1) item_date_before = item_date_before.astimezone(tzinfo=tzinfo) item_date_after = item_date + timedelta(seconds=1) item_date_after = item_date_after.astimezone(tzinfo=tzinfo)

astimezone updates the time and timezone, replace just changes the timezone.

I am getting errors in the test. Maybe we should add an issue for more comprehensive tests related to datetime parsing which is something I don't know too well.

**Description:** **Changes from 3.2.5:** #### Added - Added support for dynamically-generated queryables based on Elasticsearch/OpenSearch mappings, with extensible metadata augmentation [#351](#351) - Included default queryables configuration for seamless integration. [#351](#351) - Added support for high-performance direct response mode for both Elasticsearch and Opensearch backends, controlled by the `ENABLE_DIRECT_RESPONSE` environment variable. When enabled (`ENABLE_DIRECT_RESPONSE=true`), endpoints return Starlette Response objects directly, bypassing FastAPI's jsonable_encoder and Pydantic serialization for significantly improved performance on large search responses. **Note:** In this mode, all FastAPI dependencies (including authentication, custom status codes, and validation) are disabled for all routes. Default is `false` for safety. A warning is logged at startup if enabled. See [issue #347](#347) and [PR #359](#359). - Added robust tests for the `ENABLE_DIRECT_RESPONSE` environment variable, covering both Elasticsearch and OpenSearch backends. Tests gracefully handle missing backends by attempting to import both configs and skipping if neither is available. [#359](#359) #### Changed - Refactored database logic to reduce duplication [#351](#351) - Replaced `fastapi-slim` with `fastapi` dependency [#351](#351) - Changed minimum Python version to 3.9 [#354](#354) - Updated stac-fastapi api, types, and extensions libraries to 5.1.1 from 3.0.0 and made various associated changes [#354](#354) - Changed makefile commands from 'docker-compose' to 'docker compose' [#354](#354) - Updated package names in setup.py files to use underscores instead of periods for PEP 625 compliance [#358](#358) - Changed `stac_fastapi.opensearch` to `stac_fastapi_opensearch` - Changed `stac_fastapi.elasticsearch` to `stac_fastapi_elasticsearch` - Changed `stac_fastapi.core` to `stac_fastapi_core` - Updated all related dependencies to use the new naming convention - Renamed `docker-compose.yml` to `compose.yml` to align with Docker Compose V2 conventions [#358](#358) - Removed deprecated `version` field from all compose files [#358](#358) - Updated `STAC_FASTAPI_VERSION` environment variables to 4.0.0 in all compose files [#362](#362) - Bumped version from 4.0.0a2 to 4.0.0 for the PEP 625 compliant release [#362](#362) - Updated dependency requirements to use compatible release specifiers (~=) for more controlled updates while allowing for bug fixes and security patches [#358](#358) - Removed elasticsearch-dsl dependency as it's now part of the elasticsearch package since version 8.18.0 [#358](#358) - Updated test suite to use `httpx.ASGITransport(app=...)` for FastAPI app testing (removes deprecation warning). [#359](#359) - Updated stac-fastapi parent libraries to 5.2.0. [#359](#359) - Migrated Elasticsearch index template creation from legacy `put_template` to composable `put_index_template` API in `database_logic.py`. This resolves deprecation warnings and ensures compatibility with Elasticsearch 7.x and 8.x. [#359](#359) - Updated all Pydantic models to use `ConfigDict` instead of class-based `Config` for Pydantic v2 compatibility. This resolves deprecation warnings and prepares for Pydantic v3. [#359](#359) - Migrated all Pydantic `@root_validator` validators to `@model_validator` for Pydantic v2 compatibility. [#359](#359) - Migrated startup event handling from deprecated `@app.on_event("startup")` to FastAPI's recommended lifespan context manager. This removes deprecation warnings and ensures compatibility with future FastAPI versions. [#361](#361) - Refactored all boolean environment variable parsing in both Elasticsearch and OpenSearch backends to use the shared `get_bool_env` utility. This ensures robust and consistent handling of environment variables such as `ES_USE_SSL`, `ES_HTTP_COMPRESS`, and `ES_VERIFY_CERTS` across both backends. [#359](#359) #### Fixed - Improved performance of `mk_actions` and `filter-links` methods [#351](#351) - Fixed inheritance relating to BaseDatabaseSettings and ApiBaseSettings [#355](#355) - Fixed delete_item and delete_collection methods return types [#355](#355) - Fixed inheritance relating to DatabaseLogic and BaseDatabaseLogic, and ApiBaseSettings [#355](#355) **PR Checklist:** - [x] Code is formatted and linted (run `pre-commit run --all-files`) - [x] Tests pass (run `make test`) - [x] Documentation has been updated to reflect changes, if applicable - [x] Changes are added to the changelog

jonhealy1 added 5 commits April 12, 2025 20:26

change from 'docker-compose'

268c161

remove 'version'

4cbb4e6

update stac-fastapi tp 5.1

a93608d

change format datetime function

e06f8c0

alias not working?

893ed7f

jonhealy1 marked this pull request as draft April 12, 2025 12:30

jonhealy1 added 12 commits April 12, 2025 20:38

update core to v4.0.0

605533b

pin stac-fastapi to 5.1.1

c020469

try no-cache-dir

cf4fca0

comment out cache

b93e0ef

remove python 3.8

a21b8c8

fix tests

a1f0770

fix filter extension

d9a8502

update changelog

2c2bd42

add cache back

ba11623

switch back to filter-lang

55a36d3

change type to str

64a238d

add context

4688ab3

jonhealy1 changed the title ~~Update stac-fastapi parent libraries to 5.1.0~~ Update stac-fastapi parent libraries to 5.1.1 Apr 14, 2025

jonhealy1 requested a review from jamesfisher-geo April 14, 2025 11:18

jonhealy1 marked this pull request as ready for review April 14, 2025 11:18

jonhealy1 added 3 commits April 15, 2025 00:21

changelog fix

1de9ba5

add more info to changelog

3325672

change version to 4.0.0a0

6ada768

jonhealy1 requested a review from rhysrevans3 April 15, 2025 11:07

rhysrevans3 reviewed Apr 15, 2025

View reviewed changes

improve datetime range

7ded416

jonhealy1 requested a review from rhysrevans3 April 16, 2025 06:24

jonhealy1 mentioned this pull request Apr 16, 2025

Aggregate Extension Filter Attribute Missing #357

Closed

update date format logic, test

8b32ba8

rhysrevans3 reviewed Apr 16, 2025

View reviewed changes

rhysrevans3 approved these changes Apr 16, 2025

View reviewed changes

jonhealy1 merged commit fe37609 into main Apr 16, 2025
15 checks passed

jonhealy1 deleted the stac-fastapi-v5 branch April 16, 2025 15:09

jonhealy1 mentioned this pull request Apr 24, 2025

Update to v4.0.0 #362

Merged

4 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Update stac-fastapi parent libraries to 5.1.1 #354

Update stac-fastapi parent libraries to 5.1.1 #354

Uh oh!

jonhealy1 commented Apr 12, 2025 •

edited

Loading

Uh oh!

rhysrevans3 Apr 15, 2025

Uh oh!

jonhealy1 Apr 16, 2025

Uh oh!

rhysrevans3 Apr 16, 2025

Uh oh!

jonhealy1 Apr 16, 2025

Uh oh!

rhysrevans3 Apr 16, 2025

Uh oh!

rhysrevans3 Apr 16, 2025

Uh oh!

jonhealy1 Apr 16, 2025

Uh oh!

Uh oh!

Uh oh!

Update stac-fastapi parent libraries to 5.1.1 #354

Update stac-fastapi parent libraries to 5.1.1 #354

Uh oh!

Conversation

jonhealy1 commented Apr 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rhysrevans3 Apr 15, 2025

Choose a reason for hiding this comment

Uh oh!

jonhealy1 Apr 16, 2025

Choose a reason for hiding this comment

Uh oh!

rhysrevans3 Apr 16, 2025

Choose a reason for hiding this comment

Uh oh!

jonhealy1 Apr 16, 2025

Choose a reason for hiding this comment

Uh oh!

rhysrevans3 Apr 16, 2025

Choose a reason for hiding this comment

Uh oh!

rhysrevans3 Apr 16, 2025

Choose a reason for hiding this comment

Uh oh!

jonhealy1 Apr 16, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

jonhealy1 commented Apr 12, 2025 •

edited

Loading